Enhance error handling in EoaExecutorWorker for unsupported EIP-1559 errors (#39)

* Enhance error handling in EoaExecutorWorker for unsupported EIP-1559 errors

- Updated the error handling logic to include a new function `is_unsupported_eip1559_error`, which checks for unsupported feature errors and specific error messages related to method availability.
- Modified the transaction processing logic to utilize this new error handling function, improving the robustness of the EoaExecutorWorker's response to unsupported EIP-1559 features.

* Update tracing instrumentation in AtomicEoaExecutorStore to log transaction length instead of transactions directly.

Author: d4mr

executors/src/eoa/store/atomic.rs

@@ -141,7 +141,7 @@ impl AtomicEoaExecutorStore {
     ///
     /// The transactions must have sequential nonces starting from the current optimistic count.
     /// This operation validates nonce ordering and atomically moves all transactions.
-    #[tracing::instrument(skip_all, fields(transactions = ?transactions))]
+    #[tracing::instrument(skip_all, fields(transactions_length = transactions.len()))]
     pub async fn atomic_move_pending_to_borrowed_with_incremented_nonces(
         &self,
         transactions: &[BorrowedTransactionData],

executors/src/eoa/worker/error.rs

@@ -238,7 +238,7 @@ pub fn is_retryable_rpc_error(kind: &RpcErrorKind) -> bool {
         RpcErrorKind::ErrorResp(resp) => {
             let message = resp.message.to_lowercase();
             // if the error message contains "invalid chain", it's not retryable
-            !message.contains("invalid chain")
+            !(message.contains("invalid chain") || message.contains("invalid opcode"))
         }
         _ => true,
     }
@@ -323,3 +323,16 @@ impl SubmissionResult {
         }
     }
 }
+
+pub fn is_unsupported_eip1559_error(error: &RpcError<TransportErrorKind>) -> bool {
+    if let RpcError::UnsupportedFeature(_) = error {
+        return true;
+    }
+
+    if let RpcError::ErrorResp(resp) = error {
+        let message = resp.message.to_lowercase();
+        return message.contains("method not found");
+    }
+
+    false
+}

executors/src/eoa/worker/transaction.rs

@@ -20,14 +20,11 @@ use engine_core::{
 };
 
 use crate::eoa::{
-    EoaTransactionRequest,
     store::{
         BorrowedTransaction, BorrowedTransactionData, PendingTransaction, SubmittedNoopTransaction,
-    },
-    worker::{
-        EoaExecutorWorker,
-        error::{EoaExecutorWorkerError, is_retryable_preparation_error},
-    },
+    }, worker::{
+        error::{is_retryable_preparation_error, is_unsupported_eip1559_error, EoaExecutorWorkerError}, EoaExecutorWorker
+    }, EoaTransactionRequest
 };
 
 // Retry constants for preparation phase
@@ -199,7 +196,7 @@ impl<C: Chain> EoaExecutorWorker<C> {
             }
             Err(eip1559_error) => {
                 // Check if this is an "unsupported feature" error
-                if let RpcError::UnsupportedFeature(_) = &eip1559_error {
+                if is_unsupported_eip1559_error(&eip1559_error) {
                     tracing::debug!("EIP-1559 not supported, falling back to legacy gas price");
 
                     // Fall back to legacy gas price only if no gas price is set