Skip to content

feat(reflection): Add support for open generic types in IsOrInheritsFrom #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ted-Jin-Lab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(reflection): Add support for open generic types in IsOrInheritsFrom #1338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/ModularPipelines/Extensions/TypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,28 @@ internal static class TypeExtensions
{
public static bool IsOrInheritsFrom(this Type type, Type otherType)
{
return type == otherType || type.IsSubclassOf(otherType);
if (type == otherType)
{
return true;
}

if (!otherType.IsGenericType)
{
return type.IsSubclassOf(otherType);
}

var baseType = type.BaseType;
while (baseType is not null)
{
if (baseType.IsGenericType && baseType.GetGenericTypeDefinition() == otherType)
{
return true;
}

baseType = baseType.BaseType;
}

return false;
}

public static string GetRealTypeName(this Type type)
Expand Down