fix: corrected PHPUnit 12.5 notices

Author: thorsten

phpmyfaq/admin/assets/src/user/users.ts

@@ -223,7 +223,8 @@ export const handleUsers = async (): Promise<void> => {
             location.reload();
           }, 1500);
         } else {
-          pushErrorNotification(response.error as string);
+          const errorMessage = Array.isArray(response) ? response.join('\n') : (response as unknown as string);
+          pushErrorNotification(errorMessage);
         }
       } catch (error) {
         console.error('Error adding user: ', error);
@@ -261,7 +262,10 @@ export const handleUsers = async (): Promise<void> => {
         modal.hide();
       }
       if (response.error) {
-        pushErrorNotification(response.error);
+        const errorMessage: string = Array.isArray(response.error)
+          ? response.error.join('\n')
+          : (response.error as string);
+        pushErrorNotification(errorMessage);
       }
     });
   }
@@ -295,7 +299,8 @@ export const handleUsers = async (): Promise<void> => {
           await clearUserForm();
         }
         if (response.error) {
-          pushErrorNotification(response.error);
+          const errorMessage = Array.isArray(response.error) ? response.error.join('\n') : (response.error as string);
+          pushErrorNotification(errorMessage);
         }
       }
     });
@@ -323,7 +328,8 @@ export const handleUsers = async (): Promise<void> => {
         pushNotification(response.success);
       }
       if (response.error) {
-        pushErrorNotification(response.error);
+        const errorMessage = Array.isArray(response.error) ? response.error.join('\n') : (response.error as string);
+        pushErrorNotification(errorMessage);
       }
       await updateUser(userId);
     });
@@ -350,7 +356,8 @@ export const handleUsers = async (): Promise<void> => {
         pushNotification(response.success);
       }
       if (response.error) {
-        pushErrorNotification(response.error);
+        const errorMessage = Array.isArray(response.error) ? response.error.join('\n') : (response.error as string);
+        pushErrorNotification(errorMessage);
       }
       await updateUser(userId);
     });

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/AttachmentController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Attachment Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-26
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Attachment\AttachmentException;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/CategoryController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Category Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-27
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Category;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/CommentController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Comment Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-25
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Controller\AbstractController;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/ConfigurationController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Configuration Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-26
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Controller\AbstractController;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/DashboardController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Dashboard Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-15
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use Exception;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/ElasticsearchController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Elasticsearch Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-26
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use Elastic\Elasticsearch\Exception\ClientResponseException;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/ExportController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The File Export Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-12-23
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use JsonException;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/FormController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Form Controller
  * This Source Code Form is subject to the terms of the Mozilla Public License,
@@ -17,6 +15,8 @@
  * @since     2024-03-09
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Controller\AbstractController;

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/GlossaryController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Glossary Controller
  *
@@ -17,6 +15,8 @@
  * @since     2024-01-27
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Controller\AbstractController;