Enhance capacity pool fn #4435
Merged
Enhance capacity pool fn #4435
+25
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ql get node twinId only in case it's undefined, update CapacityPoolCheckModel
zaelgohary
requested review from
0oM4R,
AhmedHanafy725,
Mahmoud-Emad,
MohamedElmdary and
amiraabouhadid
as code owners
AhmedHanafy725
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I initially attempted to batch GraphQL requests, but realized this was unnecessary. The node object already contains the required twinId, allowing me to eliminate the extra requests. I've updated the checkNodeCapacityPool function to accept the twinId directly.
Changes
Edit checkNodeCapacityPool to include node twinId, fall back to GraphQL get node twinId only in case it's undefined, update CapacityPoolCheckModel
#3468