refactor: standardize reward field names and JSON tags in NodeCapacityReward struct

Author: 0oM4R

node-registrar/client/node_test.go

@@ -220,16 +220,16 @@ func TestGetNodeCapacityRewards(t *testing.T) {
 		require.NoError(err)
 		expected := NodeCapacityReward{
 			FarmerReward:     60.0,
-			TfReward:         20.0,
-			FpReward:         20.0,
+			TFReward:         20.0,
+			FPReward:         20.0,
 			Total:            100.0,
 			UpTimePercentage: 75.0,
 		}
 		require.Equal(expected, res)
 		// Verify reward distribution percentages are correct
 		require.InDelta(0.6, res.FarmerReward/res.Total, 0.001)
-		require.InDelta(0.2, res.TfReward/res.Total, 0.001)
-		require.InDelta(0.2, res.FpReward/res.Total, 0.001)
+		require.InDelta(0.2, res.TFReward/res.Total, 0.001)
+		require.InDelta(0.2, res.FPReward/res.Total, 0.001)
 	})
 
 	t.Run("bad request due to invalid node ID format", func(t *testing.T) {

node-registrar/client/types.go

@@ -66,9 +66,9 @@ type Location struct {
 }
 
 type NodeCapacityReward struct {
-	FarmerReward     float64 `json:"farmerReward"`     // Reward amount for the node owner (60%)
-	TfReward         float64 `json:"tfReward"`         // Reward amount for Threefold Foundation (20%)
-	FpReward         float64 `json:"fpReward"`         // Reward amount for the Farming Pool (20%)
-	Total            float64 `json:"total"`            // Total reward amount
-	UpTimePercentage float64 `json:"uptimePercentage"` // Node's uptime percentage
+	FarmerReward     float64 `json:"FarmerReward"`     // Reward amount for the node owner (60%)
+	TFReward         float64 `json:"TFReward"`         // Reward amount for Threefold Foundation (20%)
+	FPReward         float64 `json:"FPReward"`         // Reward amount for the Farming Pool (20%)
+	Total            float64 `json:"Total"`            // Total reward amount
+	UpTimePercentage float64 `json:"UptimePercentage"` // Node's uptime percentage
 }

node-registrar/client/utils_test.go

@@ -249,8 +249,8 @@ func serverHandler(r *http.Request, request, count int, require *require.Asserti
 		require.Equal(http.MethodGet, r.Method)
 		resp, err := json.Marshal(NodeCapacityReward{
 			FarmerReward:     60.0,
-			TfReward:         20.0,
-			FpReward:         20.0,
+			TFReward:         20.0,
+			FPReward:         20.0,
 			Total:            100.0,
 			UpTimePercentage: 75.0,
 		})