Skip to content

fix(ios): excluded fragment delimiter from encoding #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): excluded fragment delimiter from encoding #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ios/Classes/TiWebdialogModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ - (void)safariViewControllerDidFinish:(SFSafariViewController *)controller
- (SFSafariViewController *)safariController:(NSString *)url withEntersReaderIfAvailable:(BOOL)entersReaderIfAvailable andBarCollapsingEnabled:(BOOL)barCollapsingEnabled
{
if (_safariController == nil) {
NSString *encodedURL = [url stringByAddingPercentEncodingWithAllowedCharacters:NSCharacterSet.URLQueryAllowedCharacterSet];
NSMutableCharacterSet *allowedCharacters = [[NSCharacterSet URLQueryAllowedCharacterSet] mutableCopy];
[allowedCharacters addCharactersInString:@"#"]; // https://github.com/tidev/titanium-web-dialog/issues/329
NSString *encodedURL = [url stringByAddingPercentEncodingWithAllowedCharacters:allowedCharacters];
NSURL *safariURL = [NSURL URLWithString:encodedURL];

SFSafariViewControllerConfiguration *config = [[SFSafariViewControllerConfiguration alloc] init];
Expand Down
2 changes: 1 addition & 1 deletion ios/manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 4.0.0
version: 4.0.1
apiversion: 2
architectures: arm64 x86_64
description: titanium-web-dialog
Expand Down