Skip to content

Commit 7997f48

Browse files
hadleyhadley
authored
Add warning for 1st edition (#829)
1 parent 809c870 commit 7997f48

File tree

10 files changed

+1068
-9
lines changed

10 files changed

+1068
-9
lines changed

‎NEWS.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# dbplyr (development version)
22

3+
* The 1st edition extension mechanism is formally deprecated (#507).
4+
35
* `show_query()` now creates more readable queries by printing the most common
46
keywords in blue (@mgirlich, #644).
57

‎R/db.R‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,15 @@ dbplyr_fallback <- function(con, .generic, ...) {
8080
# Always call DBIConnection method which contains the default implementation
8181
fun <- sym(paste0(.generic, ".DBIConnection"))
8282
} else {
83+
class <- class(con)[[1]]
84+
warn(
85+
c(
86+
paste0("<", class, "> uses an old dbplyr interface"),
87+
i = "Please install a newer version of the package or contact the maintainer"
88+
),
89+
.frequency = "regularly",
90+
.frequency_id = paste0(class, "-edition")
91+
)
8392
fun <- call("::", quote(dplyr), sym(.generic))
8493
}
8594
eval_bare(expr((!!fun)(con, ...)))

‎dbplyr.Rproj‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,6 @@ StripTrailingWhitespace: Yes
1717

1818
BuildType: Package
1919
PackageUseDevtools: Yes
20+
PackageCleanBeforeInstall: Yes
2021
PackageInstallArgs: --no-multiarch --with-keep.source --install-tests
2122
PackageRoxygenize: rd,collate,namespace

‎revdep/README.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,25 @@
11
# Revdeps
22

3+
## Failed to check (4)
4+
5+
|package |version |error |warning |note |
6+
|:-------------------------------------------|:-------|:------|:-------|:----|
7+
|[apache.sedona](failures.md#apachesedona) |1.1.1 |__+1__ | |-1 |
8+
|[geospark](failures.md#geospark) |0.3.1 |__+1__ | |-2 |
9+
|[sparklyr](failures.md#sparklyr) |1.7.5 |__+1__ | |-2 |
10+
|[sparklyr.flint](failures.md#sparklyrflint) |0.2.2 |__+1__ | | |
11+
12+
## New problems (9)
13+
14+
|package |version |error |warning |note |
15+
|:-------------------------------------------|:-------|:------|:-------|:--------|
16+
|[Andromeda](problems.md#andromeda) |0.6.0 |__+2__ |__+1__ | |
17+
|[bcdata](problems.md#bcdata) |0.3.0 |__+1__ | | |
18+
|[dcmodifydb](problems.md#dcmodifydb) |0.2.0 |__+1__ | |1 |
19+
|[dittodb](problems.md#dittodb) |0.1.3 | |__+1__ |1 |
20+
|[dlookr](problems.md#dlookr) |0.5.6 | |__+1__ | |
21+
|[dplyr.teradata](problems.md#dplyrteradata) |0.4.1 |__+1__ | |1 __+1__ |
22+
|[taxadb](problems.md#taxadb) |0.1.4 |__+1__ | | |
23+
|[tidypredict](problems.md#tidypredict) |0.4.8 |__+1__ | | |
24+
|[VicmapR](problems.md#vicmapr) |0.1.8 |__+1__ | | |
25+

‎revdep/cran.md‎

Lines changed: 44 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,48 @@
11
## revdepcheck results
22

3-
We checked 60 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
3+
We checked 70 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
44

5-
* We saw 0 new problems
6-
* We failed to check 0 packages
5+
* We saw 9 new problems
6+
* We failed to check 4 packages
77

8+
Issues with CRAN packages are summarised below.
9+
10+
### New problems
11+
(This reports the first line of each new failure)
12+
13+
* Andromeda
14+
checking examples ... ERROR
15+
checking tests ... ERROR
16+
checking re-building of vignette outputs ... WARNING
17+
18+
* bcdata
19+
checking tests ... ERROR
20+
21+
* dcmodifydb
22+
checking tests ... ERROR
23+
24+
* dittodb
25+
checking re-building of vignette outputs ... WARNING
26+
27+
* dlookr
28+
checking re-building of vignette outputs ... WARNING
29+
30+
* dplyr.teradata
31+
checking tests ... ERROR
32+
checking R code for possible problems ... NOTE
33+
34+
* taxadb
35+
checking tests ... ERROR
36+
37+
* tidypredict
38+
checking tests ... ERROR
39+
40+
* VicmapR
41+
checking tests ... ERROR
42+
43+
### Failed to check
44+
45+
* apache.sedona (NA)
46+
* geospark (NA)
47+
* sparklyr (NA)
48+
* sparklyr.flint (NA)

‎revdep/failures.md‎

Lines changed: 273 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,273 @@
1-
*Wow, no problems at all. :)*
1+
# apache.sedona
2+
3+
<details>
4+
5+
* Version: 1.1.1
6+
* GitHub: NA
7+
* Source code: https://github.com/cran/apache.sedona
8+
* Date/Publication: 2021-11-23 19:40:02 UTC
9+
* Number of recursive dependencies: 61
10+
11+
Run `cloud_details(, "apache.sedona")` for more info
12+
13+
</details>
14+
15+
## Newly broken
16+
17+
* checking whether package ‘apache.sedona’ can be installed ... ERROR
18+
```
19+
Installation failed.
20+
See ‘/tmp/workdir/apache.sedona/new/apache.sedona.Rcheck/00install.out’ for details.
21+
```
22+
23+
## Newly fixed
24+
25+
* checking dependencies in R code ... NOTE
26+
```
27+
Namespaces in Imports field not imported from:
28+
‘DBI’ ‘dplyr’
29+
All declared Imports should be used.
30+
```
31+
32+
## Installation
33+
34+
### Devel
35+
36+
```
37+
* installing *source* package ‘apache.sedona’ ...
38+
** package ‘apache.sedona’ successfully unpacked and MD5 sums checked
39+
** using staged installation
40+
** R
41+
** byte-compile and prepare package for lazy loading
42+
Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
43+
Execution halted
44+
ERROR: lazy loading failed for package ‘apache.sedona’
45+
* removing ‘/tmp/workdir/apache.sedona/new/apache.sedona.Rcheck/apache.sedona’
46+
47+
48+
```
49+
### CRAN
50+
51+
```
52+
* installing *source* package ‘apache.sedona’ ...
53+
** package ‘apache.sedona’ successfully unpacked and MD5 sums checked
54+
** using staged installation
55+
** R
56+
** byte-compile and prepare package for lazy loading
57+
** help
58+
*** installing help indices
59+
** building package indices
60+
** testing if installed package can be loaded from temporary location
61+
** testing if installed package can be loaded from final location
62+
** testing if installed package keeps a record of temporary installation path
63+
* DONE (apache.sedona)
64+
65+
66+
```
67+
# geospark
68+
69+
<details>
70+
71+
* Version: 0.3.1
72+
* GitHub: https://github.com/harryprince/geospark
73+
* Source code: https://github.com/cran/geospark
74+
* Date/Publication: 2020-03-02 05:40:02 UTC
75+
* Number of recursive dependencies: 66
76+
77+
Run `cloud_details(, "geospark")` for more info
78+
79+
</details>
80+
81+
## Newly broken
82+
83+
* checking whether package ‘geospark’ can be installed ... ERROR
84+
```
85+
Installation failed.
86+
See ‘/tmp/workdir/geospark/new/geospark.Rcheck/00install.out’ for details.
87+
```
88+
89+
## Newly fixed
90+
91+
* checking dependencies in R code ... NOTE
92+
```
93+
Namespace in Imports field not imported from: ‘dbplyr’
94+
All declared Imports should be used.
95+
```
96+
97+
* checking LazyData ... NOTE
98+
```
99+
'LazyData' is specified without a 'data' directory
100+
```
101+
102+
## Installation
103+
104+
### Devel
105+
106+
```
107+
* installing *source* package ‘geospark’ ...
108+
** package ‘geospark’ successfully unpacked and MD5 sums checked
109+
** using staged installation
110+
** R
111+
** inst
112+
** byte-compile and prepare package for lazy loading
113+
Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
114+
Execution halted
115+
ERROR: lazy loading failed for package ‘geospark’
116+
* removing ‘/tmp/workdir/geospark/new/geospark.Rcheck/geospark’
117+
118+
119+
```
120+
### CRAN
121+
122+
```
123+
* installing *source* package ‘geospark’ ...
124+
** package ‘geospark’ successfully unpacked and MD5 sums checked
125+
** using staged installation
126+
** R
127+
** inst
128+
** byte-compile and prepare package for lazy loading
129+
** help
130+
*** installing help indices
131+
** building package indices
132+
** testing if installed package can be loaded from temporary location
133+
** testing if installed package can be loaded from final location
134+
** testing if installed package keeps a record of temporary installation path
135+
* DONE (geospark)
136+
137+
138+
```
139+
# sparklyr
140+
141+
<details>
142+
143+
* Version: 1.7.5
144+
* GitHub: https://github.com/sparklyr/sparklyr
145+
* Source code: https://github.com/cran/sparklyr
146+
* Date/Publication: 2022-02-02 14:30:02 UTC
147+
* Number of recursive dependencies: 107
148+
149+
Run `cloud_details(, "sparklyr")` for more info
150+
151+
</details>
152+
153+
## Newly broken
154+
155+
* checking whether package ‘sparklyr’ can be installed ... ERROR
156+
```
157+
Installation failed.
158+
See ‘/tmp/workdir/sparklyr/new/sparklyr.Rcheck/00install.out’ for details.
159+
```
160+
161+
## Newly fixed
162+
163+
* checking installed package size ... NOTE
164+
```
165+
installed size is 6.3Mb
166+
sub-directories of 1Mb or more:
167+
R 1.5Mb
168+
java 3.4Mb
169+
```
170+
171+
* checking dependencies in R code ... NOTE
172+
```
173+
Namespace in Imports field not imported from: ‘lifecycle’
174+
All declared Imports should be used.
175+
```
176+
177+
## Installation
178+
179+
### Devel
180+
181+
```
182+
* installing *source* package ‘sparklyr’ ...
183+
** package ‘sparklyr’ successfully unpacked and MD5 sums checked
184+
** using staged installation
185+
** R
186+
** inst
187+
** byte-compile and prepare package for lazy loading
188+
Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
189+
Execution halted
190+
ERROR: lazy loading failed for package ‘sparklyr’
191+
* removing ‘/tmp/workdir/sparklyr/new/sparklyr.Rcheck/sparklyr’
192+
193+
194+
```
195+
### CRAN
196+
197+
```
198+
* installing *source* package ‘sparklyr’ ...
199+
** package ‘sparklyr’ successfully unpacked and MD5 sums checked
200+
** using staged installation
201+
** R
202+
** inst
203+
** byte-compile and prepare package for lazy loading
204+
** help
205+
*** installing help indices
206+
** building package indices
207+
** testing if installed package can be loaded from temporary location
208+
** testing if installed package can be loaded from final location
209+
** testing if installed package keeps a record of temporary installation path
210+
* DONE (sparklyr)
211+
212+
213+
```
214+
# sparklyr.flint
215+
216+
<details>
217+
218+
* Version: 0.2.2
219+
* GitHub: https://github.com/r-spark/sparklyr.flint
220+
* Source code: https://github.com/cran/sparklyr.flint
221+
* Date/Publication: 2022-01-11 08:50:13 UTC
222+
* Number of recursive dependencies: 61
223+
224+
Run `cloud_details(, "sparklyr.flint")` for more info
225+
226+
</details>
227+
228+
## Newly broken
229+
230+
* checking whether package ‘sparklyr.flint’ can be installed ... ERROR
231+
```
232+
Installation failed.
233+
See ‘/tmp/workdir/sparklyr.flint/new/sparklyr.flint.Rcheck/00install.out’ for details.
234+
```
235+
236+
## Installation
237+
238+
### Devel
239+
240+
```
241+
* installing *source* package ‘sparklyr.flint’ ...
242+
** package ‘sparklyr.flint’ successfully unpacked and MD5 sums checked
243+
** using staged installation
244+
** R
245+
** inst
246+
** byte-compile and prepare package for lazy loading
247+
Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
248+
Execution halted
249+
ERROR: lazy loading failed for package ‘sparklyr.flint’
250+
* removing ‘/tmp/workdir/sparklyr.flint/new/sparklyr.flint.Rcheck/sparklyr.flint’
251+
252+
253+
```
254+
### CRAN
255+
256+
```
257+
* installing *source* package ‘sparklyr.flint’ ...
258+
** package ‘sparklyr.flint’ successfully unpacked and MD5 sums checked
259+
** using staged installation
260+
** R
261+
** inst
262+
** byte-compile and prepare package for lazy loading
263+
** help
264+
*** installing help indices
265+
** building package indices
266+
** installing vignettes
267+
** testing if installed package can be loaded from temporary location
268+
** testing if installed package can be loaded from final location
269+
** testing if installed package keeps a record of temporary installation path
270+
* DONE (sparklyr.flint)
271+
272+
273+
```

0 commit comments

Comments
 (0)