Add warning for 1st edition

NEWS.md

@@ -1,5 +1,7 @@
 # dbplyr (development version)
 
+* The 1st edition extension mechanism is formally deprecated (#507).
+
 * `show_query()` now creates more readable queries by printing the most common
   keywords in blue (@mgirlich, #644).
 

R/db.R

@@ -80,6 +80,15 @@ dbplyr_fallback <- function(con, .generic, ...) {
     # Always call DBIConnection method which contains the default implementation
     fun <- sym(paste0(.generic, ".DBIConnection"))
   } else {
+    class <- class(con)[[1]]
+    warn(
+      c(
+        paste0("<", class, "> uses an old dbplyr interface"),
+        i = "Please install a newer version of the package or contact the maintainer"
+      ),
+      .frequency = "regularly",
+      .frequency_id = paste0(class, "-edition")
+    )
     fun <- call("::", quote(dplyr), sym(.generic))
   }
   eval_bare(expr((!!fun)(con, ...)))

dbplyr.Rproj

@@ -17,5 +17,6 @@ StripTrailingWhitespace: Yes
 
 BuildType: Package
 PackageUseDevtools: Yes
+PackageCleanBeforeInstall: Yes
 PackageInstallArgs: --no-multiarch --with-keep.source --install-tests
 PackageRoxygenize: rd,collate,namespace

revdep/README.md

@@ -1,2 +1,25 @@
 # Revdeps
 
+## Failed to check (4)
+
+|package                                     |version |error  |warning |note |
+|:-------------------------------------------|:-------|:------|:-------|:----|
+|[apache.sedona](failures.md#apachesedona)   |1.1.1   |__+1__ |        |-1   |
+|[geospark](failures.md#geospark)            |0.3.1   |__+1__ |        |-2   |
+|[sparklyr](failures.md#sparklyr)            |1.7.5   |__+1__ |        |-2   |
+|[sparklyr.flint](failures.md#sparklyrflint) |0.2.2   |__+1__ |        |     |
+
+## New problems (9)
+
+|package                                     |version |error  |warning |note     |
+|:-------------------------------------------|:-------|:------|:-------|:--------|
+|[Andromeda](problems.md#andromeda)          |0.6.0   |__+2__ |__+1__  |         |
+|[bcdata](problems.md#bcdata)                |0.3.0   |__+1__ |        |         |
+|[dcmodifydb](problems.md#dcmodifydb)        |0.2.0   |__+1__ |        |1        |
+|[dittodb](problems.md#dittodb)              |0.1.3   |       |__+1__  |1        |
+|[dlookr](problems.md#dlookr)                |0.5.6   |       |__+1__  |         |
+|[dplyr.teradata](problems.md#dplyrteradata) |0.4.1   |__+1__ |        |1 __+1__ |
+|[taxadb](problems.md#taxadb)                |0.1.4   |__+1__ |        |         |
+|[tidypredict](problems.md#tidypredict)      |0.4.8   |__+1__ |        |         |
+|[VicmapR](problems.md#vicmapr)              |0.1.8   |__+1__ |        |         |
+

revdep/cran.md

@@ -1,7 +1,48 @@
 ## revdepcheck results
 
-We checked 60 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
+We checked 70 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 0 new problems
- * We failed to check 0 packages
+ * We saw 9 new problems
+ * We failed to check 4 packages
 
+Issues with CRAN packages are summarised below.
+
+### New problems
+(This reports the first line of each new failure)
+
+* Andromeda
+  checking examples ... ERROR
+  checking tests ... ERROR
+  checking re-building of vignette outputs ... WARNING
+
+* bcdata
+  checking tests ... ERROR
+
+* dcmodifydb
+  checking tests ... ERROR
+
+* dittodb
+  checking re-building of vignette outputs ... WARNING
+
+* dlookr
+  checking re-building of vignette outputs ... WARNING
+
+* dplyr.teradata
+  checking tests ... ERROR
+  checking R code for possible problems ... NOTE
+
+* taxadb
+  checking tests ... ERROR
+
+* tidypredict
+  checking tests ... ERROR
+
+* VicmapR
+  checking tests ... ERROR
+
+### Failed to check
+
+* apache.sedona  (NA)
+* geospark       (NA)
+* sparklyr       (NA)
+* sparklyr.flint (NA)

revdep/failures.md

@@ -1 +1,273 @@
-*Wow, no problems at all. :)*
+# apache.sedona
+
+<details>
+
+* Version: 1.1.1
+* GitHub: NA
+* Source code: https://github.com/cran/apache.sedona
+* Date/Publication: 2021-11-23 19:40:02 UTC
+* Number of recursive dependencies: 61
+
+Run `cloud_details(, "apache.sedona")` for more info
+
+</details>
+
+## Newly broken
+
+*   checking whether package ‘apache.sedona’ can be installed ... ERROR
+    ```
+    Installation failed.
+    See ‘/tmp/workdir/apache.sedona/new/apache.sedona.Rcheck/00install.out’ for details.
+    ```
+
+## Newly fixed
+
+*   checking dependencies in R code ... NOTE
+    ```
+    Namespaces in Imports field not imported from:
+      ‘DBI’ ‘dplyr’
+      All declared Imports should be used.
+    ```
+
+## Installation
+
+### Devel
+
+```
+* installing *source* package ‘apache.sedona’ ...
+** package ‘apache.sedona’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** byte-compile and prepare package for lazy loading
+Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
+Execution halted
+ERROR: lazy loading failed for package ‘apache.sedona’
+* removing ‘/tmp/workdir/apache.sedona/new/apache.sedona.Rcheck/apache.sedona’
+
+
+```
+### CRAN
+
+```
+* installing *source* package ‘apache.sedona’ ...
+** package ‘apache.sedona’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** byte-compile and prepare package for lazy loading
+** help
+*** installing help indices
+** building package indices
+** testing if installed package can be loaded from temporary location
+** testing if installed package can be loaded from final location
+** testing if installed package keeps a record of temporary installation path
+* DONE (apache.sedona)
+
+
+```
+# geospark
+
+<details>
+
+* Version: 0.3.1
+* GitHub: https://github.com/harryprince/geospark
+* Source code: https://github.com/cran/geospark
+* Date/Publication: 2020-03-02 05:40:02 UTC
+* Number of recursive dependencies: 66
+
+Run `cloud_details(, "geospark")` for more info
+
+</details>
+
+## Newly broken
+
+*   checking whether package ‘geospark’ can be installed ... ERROR
+    ```
+    Installation failed.
+    See ‘/tmp/workdir/geospark/new/geospark.Rcheck/00install.out’ for details.
+    ```
+
+## Newly fixed
+
+*   checking dependencies in R code ... NOTE
+    ```
+    Namespace in Imports field not imported from: ‘dbplyr’
+      All declared Imports should be used.
+    ```
+
+*   checking LazyData ... NOTE
+    ```
+      'LazyData' is specified without a 'data' directory
+    ```
+
+## Installation
+
+### Devel
+
+```
+* installing *source* package ‘geospark’ ...
+** package ‘geospark’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
+Execution halted
+ERROR: lazy loading failed for package ‘geospark’
+* removing ‘/tmp/workdir/geospark/new/geospark.Rcheck/geospark’
+
+
+```
+### CRAN
+
+```
+* installing *source* package ‘geospark’ ...
+** package ‘geospark’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+** help
+*** installing help indices
+** building package indices
+** testing if installed package can be loaded from temporary location
+** testing if installed package can be loaded from final location
+** testing if installed package keeps a record of temporary installation path
+* DONE (geospark)
+
+
+```
+# sparklyr
+
+<details>
+
+* Version: 1.7.5
+* GitHub: https://github.com/sparklyr/sparklyr
+* Source code: https://github.com/cran/sparklyr
+* Date/Publication: 2022-02-02 14:30:02 UTC
+* Number of recursive dependencies: 107
+
+Run `cloud_details(, "sparklyr")` for more info
+
+</details>
+
+## Newly broken
+
+*   checking whether package ‘sparklyr’ can be installed ... ERROR
+    ```
+    Installation failed.
+    See ‘/tmp/workdir/sparklyr/new/sparklyr.Rcheck/00install.out’ for details.
+    ```
+
+## Newly fixed
+
+*   checking installed package size ... NOTE
+    ```
+      installed size is  6.3Mb
+      sub-directories of 1Mb or more:
+        R      1.5Mb
+        java   3.4Mb
+    ```
+
+*   checking dependencies in R code ... NOTE
+    ```
+    Namespace in Imports field not imported from: ‘lifecycle’
+      All declared Imports should be used.
+    ```
+
+## Installation
+
+### Devel
+
+```
+* installing *source* package ‘sparklyr’ ...
+** package ‘sparklyr’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
+Execution halted
+ERROR: lazy loading failed for package ‘sparklyr’
+* removing ‘/tmp/workdir/sparklyr/new/sparklyr.Rcheck/sparklyr’
+
+
+```
+### CRAN
+
+```
+* installing *source* package ‘sparklyr’ ...
+** package ‘sparklyr’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+** help
+*** installing help indices
+** building package indices
+** testing if installed package can be loaded from temporary location
+** testing if installed package can be loaded from final location
+** testing if installed package keeps a record of temporary installation path
+* DONE (sparklyr)
+
+
+```
+# sparklyr.flint
+
+<details>
+
+* Version: 0.2.2
+* GitHub: https://github.com/r-spark/sparklyr.flint
+* Source code: https://github.com/cran/sparklyr.flint
+* Date/Publication: 2022-01-11 08:50:13 UTC
+* Number of recursive dependencies: 61
+
+Run `cloud_details(, "sparklyr.flint")` for more info
+
+</details>
+
+## Newly broken
+
+*   checking whether package ‘sparklyr.flint’ can be installed ... ERROR
+    ```
+    Installation failed.
+    See ‘/tmp/workdir/sparklyr.flint/new/sparklyr.flint.Rcheck/00install.out’ for details.
+    ```
+
+## Installation
+
+### Devel
+
+```
+* installing *source* package ‘sparklyr.flint’ ...
+** package ‘sparklyr.flint’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+Error: object ‘add_op_single’ is not exported by 'namespace:dbplyr'
+Execution halted
+ERROR: lazy loading failed for package ‘sparklyr.flint’
+* removing ‘/tmp/workdir/sparklyr.flint/new/sparklyr.flint.Rcheck/sparklyr.flint’
+
+
+```
+### CRAN
+
+```
+* installing *source* package ‘sparklyr.flint’ ...
+** package ‘sparklyr.flint’ successfully unpacked and MD5 sums checked
+** using staged installation
+** R
+** inst
+** byte-compile and prepare package for lazy loading
+** help
+*** installing help indices
+** building package indices
+** installing vignettes
+** testing if installed package can be loaded from temporary location
+** testing if installed package can be loaded from final location
+** testing if installed package keeps a record of temporary installation path
+* DONE (sparklyr.flint)
+
+
+```