-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Quarto vignettes #6241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto vignettes #6241
Conversation
… into quarto_vignettes # Conflicts: # vignettes/.gitignore
|
I think this gets stuck on r-lib/pkgdown#2821, so it might be best to wait for this until the next pkgdown version arrives on CRAN. |
Merge branch 'main' into quarto_vignettes # Conflicts: # DESCRIPTION
|
pkgdown seems to now work correctly, so I'm undrafting this PR |
|
I'm quite fond of being able to set global chunk options in the front matter, e.g. (from the plumber2 vignettes) I think we should update our vignettes to move it |
I agree this is sensible. There was an unexpected CI error on old windows, where I followed workaround mentioned here: quarto-dev/quarto-r#217 (comment) |
thomasp85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR aims to fix #5760.
I think I did everything correctly, but I'd be wise for somebody with more experience with quarto to take a glance.