Selecting a macro in Mod Mail prevents messaging as self

[baseballlover723]

If you select a macro in the Mod Mail screen, the whole bottom row (macros, reply as, send) disappears. Send is replaced by post macro, and losing the macro dropdown isn't that impactful (since you can just reload the page to get it back), though that doesn't consider that you can edit the message still after selecting the macro (and maybe I guess you might want to select the original macro to reset it, or a different one in case of a misclick).

But I think the most important thing that is lost is losing the ability to select who it gets sent from. I make a point to always respond from myself and not from the subreddit account, and if I use a macro, I can't do that anymore. I'm not sure why the whole bottom bar gets removed upon using a macro nor have I looked at the code at all to know what kind of dragons are involved here.

But it would be nice to be able to retain the ability to select from whom the Mod Mail is being sent from (bonus points if this is something that can be configured for an account). I rather hopeful that this isn't a huge change. and that something like just not removing that select is more or less sufficient.

[eritbh]

Sending macros in modmail doesn't actually use any API to send the reply - it does it by setting the text box's value via $.val(), then $.click()ing the "reply" button:

reddit-moderator-toolbox/extension/data/modules/macros.js

Lines 427 to 428 in 05791e7

	$body.find('.Textarea.ThreadViewerReplyForm__replyText ').val(editedcomment);
	$body.find('.ThreadViewerReplyForm__replyButton').click();

This means that as a workaround, you can select the "reply as myself" (or "create a private moderator note" for that matter) before sending the macro and it will apply to the macro message. You can do this before selecting the macro from the dropdown, or you can move the macro window out of the way to reveal the control again and change it then.

It would be easy to support this properly by creating a copy of the "send as" dropdown in the modnotes popup, and copying its value to the original one before sending the reply. I would accept a PR which does that.

Some subs may also want the ability to set a particular "send as" setting for each individual macro; this would make it possible to consistently leave private replies via macros. This would involve adding a new field to macro storage, and new UI for the macro editor to set its value. Then, the dropdown would default to the value set on the macro rather than your current selection. This should be done as a separate issue/PR, I think, since messing with storage stuff broadens the scope of the issue pretty significantly.