-
Notifications
You must be signed in to change notification settings - Fork 43
Use fsspec in everything #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ab-api into add/use-fsspec
dadmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent to Deep but just recording so we can keep track:
I get AttributeError: 'float' object has no attribute 'timestamp' from line 104 in routers/experiment/documents.py line 104. Looks like timestamp might be getting returned as a float now instead of object or something?
should be fixed now |
|
This all works for me. Will wait for us to release SDK tomorrow and verify all tests etc. look good and then we'll merge! |
|
Waiting for for build on Nov 13 before merging |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
depends on transformerlab/transformerlab-sdk#54