From 8052827562ece77f7459da534dd0ffc9f7d23ae8 Mon Sep 17 00:00:00 2001 From: maxime laine Date: Thu, 6 Mar 2025 11:10:53 +0100 Subject: [PATCH 1/3] update bingind.gyp to compile with cpp20 flag --- binding.gyp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/binding.gyp b/binding.gyp index bb40aa7..1e1641b 100644 --- a/binding.gyp +++ b/binding.gyp @@ -25,13 +25,13 @@ "NAPI_VERSION=<(napi_build_version)", ], "cflags_cc": [ - "-std=c++17" + "-std=c++20" ], "conditions": [ ["OS=='mac'", { "xcode_settings": { "GCC_SYMBOLS_PRIVATE_EXTERN": "YES", # -fvisibility=hidden - "CLANG_CXX_LANGUAGE_STANDARD": "c++17", + "CLANG_CXX_LANGUAGE_STANDARD": "c++20", "MACOSX_DEPLOYMENT_TARGET": "10.9", }, }], @@ -39,7 +39,7 @@ "msvs_settings": { "VCCLCompilerTool": { "AdditionalOptions": [ - "/std:c++17", + "/std:c++20", ], "RuntimeLibrary": 0, }, From ccd8fd0f3e91d7167ba638a9f9c70e3f7d1194fb Mon Sep 17 00:00:00 2001 From: maxime laine Date: Tue, 25 Mar 2025 17:45:17 +0100 Subject: [PATCH 2/3] added ci for node 24 --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 902b2b5..3a86a50 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,6 +25,7 @@ jobs: - 18 - 20 - 22 + - 24 fail-fast: false name: Test Node ${{ matrix.node }} on ${{ matrix.os }} runs-on: ${{ matrix.os }} From 134b6db26919f871ee1c2ce73bc8e5305fd108a5 Mon Sep 17 00:00:00 2001 From: maxime laine Date: Tue, 25 Mar 2025 17:46:29 +0100 Subject: [PATCH 3/3] corrected to node 23 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a86a50..eb449ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,7 +25,7 @@ jobs: - 18 - 20 - 22 - - 24 + - 23 fail-fast: false name: Test Node ${{ matrix.node }} on ${{ matrix.os }} runs-on: ${{ matrix.os }}