use deploy shortcode instead of new nanoid

Author: nicktrn

apps/webapp/app/v3/getDeploymentImageRef.server.ts

@@ -12,9 +12,6 @@ import { tryCatch } from "@trigger.dev/core";
 import { logger } from "~/services/logger.server";
 import { type RegistryConfig } from "./registryConfig.server";
 import type { EnvironmentType } from "@trigger.dev/core/v3";
-import { customAlphabet } from "nanoid";
-
-const nanoid = customAlphabet("1234567890abcdefghijklmnopqrstuvwxyz", 8);
 
 // Optional configuration for cross-account access
 export type AssumeRoleConfig = {
@@ -106,20 +103,21 @@ export async function getDeploymentImageRef({
   projectRef,
   nextVersion,
   environmentType,
+  deploymentShortCode,
 }: {
   registry: RegistryConfig;
   projectRef: string;
   nextVersion: string;
   environmentType: EnvironmentType;
+  deploymentShortCode: string;
 }): Promise<{
   imageRef: string;
   isEcr: boolean;
   repoCreated: boolean;
 }> {
   const repositoryName = `${registry.namespace}/${projectRef}`;
   const envType = environmentType.toLowerCase();
-  const randomSuffix = nanoid();
-  const imageRef = `${registry.host}/${repositoryName}:${nextVersion}.${envType}.${randomSuffix}`;
+  const imageRef = `${registry.host}/${repositoryName}:${nextVersion}.${envType}.${deploymentShortCode}`;
 
   if (!isEcrRegistry(registry.host)) {
     return {

apps/webapp/app/v3/services/initializeDeployment.server.ts

@@ -73,12 +73,15 @@ export class InitializeDeploymentService extends BaseService {
       const isV4Deployment = payload.type === "MANAGED";
       const registryConfig = getRegistryConfig(isV4Deployment);
 
+      const deploymentShortCode = nanoid(8);
+
       const [imageRefError, imageRefResult] = await tryCatch(
         getDeploymentImageRef({
           registry: registryConfig,
           projectRef: environment.project.externalRef,
           nextVersion,
           environmentType: environment.type,
+          deploymentShortCode,
         })
       );
 
@@ -111,7 +114,7 @@ export class InitializeDeploymentService extends BaseService {
         data: {
           friendlyId: generateFriendlyId("deployment"),
           contentHash: payload.contentHash,
-          shortCode: nanoid(8),
+          shortCode: deploymentShortCode,
           version: nextVersion,
           status: "BUILDING",
           environmentId: environment.id,

apps/webapp/test/getDeploymentImageRef.test.ts

@@ -70,14 +70,15 @@ describe("getDeploymentImageRef", () => {
       projectRef: testProjectRef,
       nextVersion: "20250630.1",
       environmentType: "DEVELOPMENT",
+      deploymentShortCode: "test1234",
     });
 
     // Check the image ref structure and that it contains expected parts
     expect(imageRef.imageRef).toMatch(
       new RegExp(
         `^${escapeHostForRegex(
           "registry.example.com"
-        )}/${testNamespace}/${testProjectRef}:20250630\\.1\\.development\\.[a-z0-9]{8}$`
+        )}/${testNamespace}/${testProjectRef}:20250630\\.1\\.development\\.test1234$`
       )
     );
     expect(imageRef.isEcr).toBe(false);
@@ -99,13 +100,14 @@ describe("getDeploymentImageRef", () => {
         projectRef: testProjectRef2,
         nextVersion: "20250630.1",
         environmentType: "DEVELOPMENT",
+        deploymentShortCode: "test1234",
       });
 
       expect(imageRef1.imageRef).toMatch(
         new RegExp(
           `^${escapeHostForRegex(
             testHost
-          )}/${testNamespace}/${testProjectRef2}:20250630\\.1\\.development\\.[a-z0-9]{8}$`
+          )}/${testNamespace}/${testProjectRef2}:20250630\\.1\\.development\\.test1234$`
         )
       );
       expect(imageRef1.isEcr).toBe(true);
@@ -124,13 +126,14 @@ describe("getDeploymentImageRef", () => {
         projectRef: testProjectRef2,
         nextVersion: "20250630.2",
         environmentType: "DEVELOPMENT",
+        deploymentShortCode: "test1234",
       });
 
       expect(imageRef2.imageRef).toMatch(
         new RegExp(
           `^${escapeHostForRegex(
             testHost
-          )}/${testNamespace}/${testProjectRef2}:20250630\\.2\\.development\\.[a-z0-9]{8}$`
+          )}/${testNamespace}/${testProjectRef2}:20250630\\.2\\.development\\.test1234$`
         )
       );
       expect(imageRef2.isEcr).toBe(true);
@@ -153,13 +156,14 @@ describe("getDeploymentImageRef", () => {
       projectRef: testProjectRef,
       nextVersion: "20250630.2",
       environmentType: "PRODUCTION",
+      deploymentShortCode: "test1234",
     });
 
     expect(imageRef.imageRef).toMatch(
       new RegExp(
         `^${escapeHostForRegex(
           testHost
-        )}/${testNamespace}/${testProjectRef}:20250630\\.2\\.production\\.[a-z0-9]{8}$`
+        )}/${testNamespace}/${testProjectRef}:20250630\\.2\\.production\\.test1234$`
       )
     );
     expect(imageRef.isEcr).toBe(true);
@@ -183,6 +187,7 @@ describe("getDeploymentImageRef", () => {
       projectRef: testProjectRef,
       nextVersion: sameVersion,
       environmentType: sameEnvironmentType,
+      deploymentShortCode: "test1234",
     });
 
     const secondImageRef = await getDeploymentImageRef({
@@ -198,21 +203,22 @@ describe("getDeploymentImageRef", () => {
       projectRef: testProjectRef,
       nextVersion: sameVersion,
       environmentType: sameEnvironmentType,
+      deploymentShortCode: "test4321",
     });
 
     // Even with the same environment type and version, the image refs should be different due to random suffix
     expect(firstImageRef.imageRef).toMatch(
       new RegExp(
         `^${escapeHostForRegex(
           "registry.example.com"
-        )}/${testNamespace}/${testProjectRef}:${sameVersion}\\.preview\\.[a-z0-9]{8}$`
+        )}/${testNamespace}/${testProjectRef}:${sameVersion}\\.preview\\.test1234$`
       )
     );
     expect(secondImageRef.imageRef).toMatch(
       new RegExp(
         `^${escapeHostForRegex(
           "registry.example.com"
-        )}/${testNamespace}/${testProjectRef}:${sameVersion}\\.preview\\.[a-z0-9]{8}$`
+        )}/${testNamespace}/${testProjectRef}:${sameVersion}\\.preview\\.test4321$`
       )
     );
     expect(firstImageRef.imageRef).not.toBe(secondImageRef.imageRef);