Skip to content

Commit 6311840

Browse files
committed
Deal with encoded characters better
1 parent 7135b71 commit 6311840

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

apps/webapp/app/components/runs/v3/RunFilters.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ export function getRunFiltersFromSearchParams(
280280
bulkId: searchParams.get("bulkId") ?? undefined,
281281
tags:
282282
searchParams.getAll("tags").filter((v) => v.length > 0).length > 0
283-
? searchParams.getAll("tags").map((t) => decodeURIComponent(t))
283+
? searchParams.getAll("tags")
284284
: undefined,
285285
from: searchParams.get("from") ?? undefined,
286286
to: searchParams.get("to") ?? undefined,
@@ -836,7 +836,7 @@ function TagsDropdown({
836836
useEffect(() => {
837837
const searchParams = new URLSearchParams();
838838
if (searchValue) {
839-
searchParams.set("name", encodeURIComponent(searchValue));
839+
searchParams.set("name", searchValue);
840840
}
841841
if (period) {
842842
searchParams.set("period", period);
@@ -973,7 +973,7 @@ function QueuesDropdown({
973973
const searchParams = new URLSearchParams();
974974
searchParams.set("per_page", "25");
975975
if (searchValue) {
976-
searchParams.set("query", encodeURIComponent(s));
976+
searchParams.set("query", s);
977977
}
978978
fetcher.load(
979979
`/resources/orgs/${organization.slug}/projects/${project.slug}/env/${
@@ -1235,7 +1235,7 @@ function VersionsDropdown({
12351235
(s) => {
12361236
const searchParams = new URLSearchParams();
12371237
if (searchValue) {
1238-
searchParams.set("query", encodeURIComponent(s));
1238+
searchParams.set("query", s);
12391239
}
12401240
fetcher.load(
12411241
`/resources/orgs/${organization.slug}/projects/${project.slug}/env/${

apps/webapp/app/routes/resources.environments.$envId.runs.tags.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,9 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
3434
}
3535

3636
const search = new URL(request.url).searchParams;
37-
const name = search.get("name");
3837

3938
const parsedSearchParams = SearchParams.safeParse({
40-
name: name ? decodeURIComponent(name) : undefined,
39+
name: search.get("name") ?? undefined,
4140
period: search.get("period") ?? undefined,
4241
from: search.get("from") ?? undefined,
4342
to: search.get("to") ?? undefined,

0 commit comments

Comments
 (0)