Don't ack the heartbeat if there's a mismatch, it might prevent a brand new one

matt-aitken · matt-aitken · commit 8c11a6a22c08 · 2025-08-11T17:21:43.000+01:00
diff --git a/internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts b/internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts
@@ -361,7 +361,6 @@ export class ExecutionSnapshotSystem {
         runnerId,
       });
 
-      await this.$.worker.ack(`heartbeatSnapshot.${runId}`);
       return executionResultFromSnapshot(latestSnapshot);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,6 @@ export class ExecutionSnapshotSystem {`
`361`	`361`	`runnerId,`
`362`	`362`	`});`
`363`	`363`
`364`		- await this.$.worker.ack(`heartbeatSnapshot.${runId}`);
`365`	`364`	`return executionResultFromSnapshot(latestSnapshot);`
`366`	`365`	`}`
`367`	`366`