Skip to content

Commit f2caa3f

Browse files
committed
Fix for wrong items being checked
1 parent e3d61a8 commit f2caa3f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

apps/webapp/app/components/runs/v3/RunFilters.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ function AppliedFilters({ possibleTasks, bulkActions }: RunFiltersProps) {
421421
<>
422422
<AppliedStatusFilter />
423423
<AppliedTaskFilter possibleTasks={possibleTasks} />
424-
<AppliedTagsFilter />
424+
{/* <AppliedTagsFilter /> */}
425425
<AppliedVersionsFilter />
426426
<AppliedQueuesFilter />
427427
<AppliedMachinesFilter />
@@ -853,7 +853,7 @@ function TagsDropdown({
853853
const filtered = useMemo(() => {
854854
let items: string[] = [];
855855
if (searchValue === "") {
856-
items = selected ?? [];
856+
items = [...(selected ?? [])];
857857
}
858858

859859
if (fetcher.data === undefined) {
@@ -863,7 +863,7 @@ function TagsDropdown({
863863
items.push(...fetcher.data.tags);
864864

865865
return matchSorter(Array.from(new Set(items)), searchValue);
866-
}, [searchValue, fetcher.data]);
866+
}, [searchValue, fetcher.data, selected]);
867867

868868
return (
869869
<SelectProvider value={selected ?? []} setValue={handleChange} virtualFocus={true}>

0 commit comments

Comments
 (0)