Retain rollback exception as suppressed

findepi · findepi · commit 031569d02898 · 2025-11-20T14:59:16.000+01:00
No need to swallow it. Keep for visibility.
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetFileWriter.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetFileWriter.java
@@ -147,13 +147,14 @@ public Closeable commit()
             parquetWriter.close();
         }
         catch (IOException | UncheckedIOException e) {
+            TrinoException trinoException = new TrinoException(HIVE_WRITER_CLOSE_ERROR, "Error committing write to Parquet file", e);
             try {
                 rollbackAction.close();
             }
-            catch (Exception _) {
-                // ignore
+            catch (Exception rollbackException) {
+                trinoException.addSuppressed(rollbackException);
             }
-            throw new TrinoException(HIVE_WRITER_CLOSE_ERROR, "Error committing write to Parquet file", e);
+            throw trinoException;
         }
 
         if (validationInputFactory.isPresent()) {

Original file line number	Diff line number	Diff line change
`@@ -147,13 +147,14 @@ public Closeable commit()`
`147`	`147`	`parquetWriter.close();`
`148`	`148`	`}`
`149`	`149`	`catch (IOException \| UncheckedIOException e) {`
	`150`	`+ TrinoException trinoException = new TrinoException(HIVE_WRITER_CLOSE_ERROR, "Error committing write to Parquet file", e);`
`150`	`151`	`try {`
`151`	`152`	`rollbackAction.close();`
`152`	`153`	`}`
`153`		`- catch (Exception _) {`
`154`		`- // ignore`
	`154`	`+ catch (Exception rollbackException) {`
	`155`	`+ trinoException.addSuppressed(rollbackException);`
`155`	`156`	`}`
`156`		`- throw new TrinoException(HIVE_WRITER_CLOSE_ERROR, "Error committing write to Parquet file", e);`
	`157`	`+ throw trinoException;`
`157`	`158`	`}`
`158`	`159`
`159`	`160`	`if (validationInputFactory.isPresent()) {`