Skip to content

Commit ebcd45f

Browse files
committed
Deprecate join-pushdown.with-expressions config property
Deprecate `join-pushdown.with-expressions` config property and associated `complex_join_pushdown_enabled` session property. It was added for transition period when join pushdown behavior was being build out. Removing it will allow simplifying code.
1 parent f94b311 commit ebcd45f

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,13 @@ public JdbcMetadataConfig setJoinPushdownEnabled(boolean joinPushdownEnabled)
7171
return this;
7272
}
7373

74+
@Deprecated
7475
public boolean isComplexJoinPushdownEnabled()
7576
{
7677
return complexJoinPushdownEnabled;
7778
}
7879

80+
@Deprecated
7981
@Config("join-pushdown.with-expressions")
8082
@ConfigDescription("Enable join pushdown with complex expressions")
8183
public JdbcMetadataConfig setComplexJoinPushdownEnabled(boolean complexJoinPushdownEnabled)

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public class JdbcMetadataSessionProperties
3333
{
3434
public static final String COMPLEX_EXPRESSION_PUSHDOWN = "complex_expression_pushdown";
3535
public static final String JOIN_PUSHDOWN_ENABLED = "join_pushdown_enabled";
36+
@Deprecated
3637
public static final String COMPLEX_JOIN_PUSHDOWN_ENABLED = "complex_join_pushdown_enabled";
3738
public static final String AGGREGATION_PUSHDOWN_ENABLED = "aggregation_pushdown_enabled";
3839
public static final String TOPN_PUSHDOWN_ENABLED = "topn_pushdown_enabled";
@@ -102,6 +103,7 @@ public static boolean isJoinPushdownEnabled(ConnectorSession session)
102103
return session.getProperty(JOIN_PUSHDOWN_ENABLED, Boolean.class);
103104
}
104105

106+
@Deprecated
105107
public static boolean isComplexJoinPushdownEnabled(ConnectorSession session)
106108
{
107109
return session.getProperty(COMPLEX_JOIN_PUSHDOWN_ENABLED, Boolean.class);

0 commit comments

Comments
 (0)