Highlight should higlight all removed lettrs

[koppor]

Context: JabRef/jabref#12990

Exception removed - code removed it including throws, but rendering still shows throws

[tsantalis]

@pouryafard75
Is this issue fixable?

I know that the Java-reserved keywords are not part of the AST, and this is the reason we cannot highlight it.
Please give me a confirmation.

[pouryafard75]

@tsantalis Not with the current visitor.

There are still some keywords we don't capture: permits, implements, throws, and extends.

Updating the ground truth doesn’t seem particularly difficult, but I’m not sure how beneficial it would be to include these keywords in the tree representation.

There’s nothing blocking us from addressing the issue — as I mentioned, the ground truth can be updated automatically as well.

If you believe this is an important change, we would need to identify and handle all missing subtrees. So far, I’m aware of the following four:

• permits
• implements
• throws
• extends

[tsantalis]

@pouryafard75
The diff visually does not make sense as the keyword gets deleted and this is not shown.
Since we did so much work to advance the tree structure, I think we should also make this change and include the keywords followed by a list of types.

Since the benchmark can be automatically updated, we should do it.

[pouryafard75]

@tsantalis Have you spotted any other words that I missed in my list? I want to perform the migration, just confirming that I am not missing anything.

[tsantalis]

Here are all the properties that are lists in Eclipse JDT
https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fcore%2Fdom%2FTypeDeclaration.html

I didn't find any other cases that have a Java-reserved keyword.
There are some directives in module-info that have a keyword followed by list, but we don't have such cases in our dataset

ProvidesDirective:
provides Name with Name {, Name } ;

ExportsDirective:
exports PackageName [ to ModuleName {, ModuleName } ] ;

OpensDirective:
opens PackageName [ to ModuleName {, ModuleName } ] ;

In the official Javadoc, these keywords are inside square brackets [ ].

ClassDeclaration:
[ Javadoc ] { ExtendedModifier } class Identifier
[ < TypeParameter { , TypeParameter } > ]
[ extends Type ]
[ implements Type { , Type } ]
[ permits Type { , Type } ]
{ { ClassBodyDeclaration | ; } }

[tsantalis]

@pouryafard75
Can you please add your solution in our code? There is no point waiting for Gumtree.

[tsantalis]

@pouryafard75
The PR has been merged in GumTree. Please let's fix this issue.

[tsantalis]

Thank you @pouryafard75
@koppor
The issue has been fixed.

[koppor]

Related a place, where I have much cognitive load to spot the difference

(at PR JabRef/jabref#13553)