Review comments

Author: JuergenWiemers

CHANGES.md

@@ -6,6 +6,9 @@ releases are available on [Anaconda.org](https://anaconda.org/conda-forge/gettsi
 
 ## Unreleased
 
+- {gh}`1076` Optimize `bürgergeld__in_anderer_bg_als_kindergeldempfänger`
+  ({ghuser}`JuergenWiemers`)
+
 - {gh}`1072` How-to guide for `plot.dag.tt` ({ghuser}`hmgaudecker`)
 
 ## v1.0a2 — 2025-08-09

src/gettsim/germany/arbeitslosengeld_2/kindergeldübertrag.py

@@ -134,15 +134,11 @@ def in_anderer_bg_als_kindergeldempfänger(
     """True if the person is in a different Bedarfsgemeinschaft than the
     Kindergeldempfänger of that person.
     """
-    # Create a mask for the kindergeld__p_id_empfänger
-    # Map each kindergeld__p_id_empfänger to its corresponding bg_id
-    empf_bg_id = join(
+    bg_id_empfänger = join(
         foreign_key=kindergeld__p_id_empfänger,
         primary_key=p_id,
         target=bg_id,
         value_if_foreign_key_is_missing=-1,
         xnp=xnp,
     )
-
-    # Compare bg_id array with the mapped bg_ids of kindergeld__p_id_empfänger
-    return empf_bg_id != bg_id
+    return bg_id_empfänger != bg_id

src/gettsim/germany/bürgergeld/kindergeldübertrag.py

@@ -119,15 +119,11 @@ def in_anderer_bg_als_kindergeldempfänger(
     """True if the person is in a different Bedarfsgemeinschaft than the
     Kindergeldempfänger of that person.
     """
-    # Create a mask for the kindergeld__p_id_empfänger
-    # Map each kindergeld__p_id_empfänger to its corresponding bg_id
-    empf_bg_id = join(
+    bg_id_empfänger = join(
         foreign_key=kindergeld__p_id_empfänger,
         primary_key=p_id,
         target=bg_id,
         value_if_foreign_key_is_missing=-1,
         xnp=xnp,
     )
-
-    # Compare bg_id array with the mapped bg_ids of kindergeld__p_id_empfänger
-    return empf_bg_id != bg_id
+    return bg_id_empfänger != bg_id

src/gettsim/germany/ids.py

@@ -132,8 +132,7 @@ def sgb_ii_fg_id_formula(
         isin = xnp.isin
 
     children = isin(sorted_p_id, sorted_p_id_elternteil_1) | isin(
-        sorted_p_id,
-        sorted_p_id_elternteil_2,
+        sorted_p_id, sorted_p_id_elternteil_2
     )
 
     # Assign the same fg_id to everybody who has an Einstandspartner,