PERFORMANCE

Author: penberg

src/lib.rs

@@ -598,9 +598,10 @@ impl Statement {
             Ok::<_, napi::Error>(rows)
         };
         env.execute_tokio_future(future, move |&mut _env, result| {
-            let mut column_names = vec![];
+            let mut column_names = Vec::new();
             for i in 0..result.column_count() {
-                column_names.push(result.column_name(i).unwrap().to_string());
+                let column_name = result.column_name(i).unwrap().to_string();
+                column_names.push(std::ffi::CString::new(column_name).unwrap());
             }
             let iter = RowsIterator::new(
                 Arc::new(tokio::sync::Mutex::new(result)),
@@ -632,9 +633,9 @@ impl Statement {
                 params
             };
             let rows = stmt.query(params).await.map_err(Error::from)?;
-            let mut column_names = vec![];  
+            let mut column_names = Vec::new();
             for i in 0..rows.column_count() {
-                column_names.push(rows.column_name(i).unwrap().to_string());
+                column_names.push(std::ffi::CString::new(rows.column_name(i).unwrap().to_string()).unwrap());
             }
             Ok::<_, napi::Error>((rows, column_names))
         };
@@ -723,9 +724,9 @@ impl Statement {
                 libsql::params::Params::None
             };
             let mut rows = stmt.query(params).await.map_err(Error::from)?;
-            let mut column_names = vec![];
+            let mut column_names = Vec::new();
             for i in 0..rows.column_count() {
-                column_names.push(rows.column_name(i).unwrap().to_string());
+                column_names.push(std::ffi::CString::new(rows.column_name(i).unwrap().to_string()).unwrap());
             }
             let row = rows.next().await.map_err(Error::from)?;
             let duration = start.elapsed().as_secs_f64();
@@ -776,7 +777,7 @@ impl Statement {
 #[napi]
 pub struct RowsIterator {
     rows: Arc<tokio::sync::Mutex<libsql::Rows>>,
-    column_names: Vec<String>,
+    column_names: Vec<std::ffi::CString>,
     safe_ints: bool,
     raw: bool,
     pluck: bool,
@@ -786,7 +787,7 @@ pub struct RowsIterator {
 impl RowsIterator {
     pub fn new(
         rows: Arc<tokio::sync::Mutex<libsql::Rows>>,
-        column_names: Vec<String>,
+        column_names: Vec<std::ffi::CString>,
         safe_ints: bool,
         raw: bool,
         pluck: bool,
@@ -831,7 +832,7 @@ impl RowsIterator {
 
 #[napi]
 pub struct Record {
-    column_names: Vec<String>,
+    column_names: Vec<std::ffi::CString>,
     row: Option<libsql::Row>,
     safe_ints: bool,
     raw: bool,
@@ -864,7 +865,7 @@ fn runtime() -> Result<&'static Runtime> {
 
 fn map_row(
     env: &Env,
-    column_names: &[String],
+    column_names: &[std::ffi::CString],
     row: &libsql::Row,
     safe_ints: bool,
     raw: bool,
@@ -900,7 +901,7 @@ fn convert_value_to_js(
 
 fn map_row_object(
     env: &Env,
-    column_names: &[String],
+    column_names: &[std::ffi::CString],
     row: &libsql::Row,
     safe_ints: bool,
     pluck: bool,
@@ -927,9 +928,8 @@ fn map_row_object(
                 Err(e) => return Err(napi::Error::from_reason(e.to_string())),
             };
 
-            let column_name = column_names[idx].as_str();
+            let column_name = &column_names[idx];
             let js_value = convert_value_to_js(env, &value, safe_ints)?;
-            let column_name = std::ffi::CString::new(column_name).unwrap();
             unsafe {
                 napi::sys::napi_set_named_property(
                     env.raw(),
@@ -947,7 +947,7 @@ fn map_row_object(
 
 fn map_row_raw(
     env: &Env,
-    column_names: &[String],
+    column_names: &[std::ffi::CString],
     row: &libsql::Row,
     safe_ints: bool,
     pluck: bool,