Skip to content

Commit 1ad9516

Browse files
committed
refactor: update serverless-api to v4
1 parent 758d026 commit 1ad9516

File tree

13 files changed

+60
-41
lines changed

13 files changed

+60
-41
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [2.8.0-beta.1](https://github.com/twilio-labs/twilio-run/compare/v2.7.0...v2.8.0-beta.1) (2020-07-08)
6+
7+
8+
### Features
9+
10+
* add better system env support ([#146](https://github.com/twilio-labs/twilio-run/issues/146)) ([7411e33](https://github.com/twilio-labs/twilio-run/commit/7411e334ad2fa90a0610a7381e5e0b6ee8564f99)), closes [#144](https://github.com/twilio-labs/twilio-run/issues/144)
11+
* **runtime:** experimental: load functions in a separate process ([#147](https://github.com/twilio-labs/twilio-run/issues/147)) ([0a4f542](https://github.com/twilio-labs/twilio-run/commit/0a4f542a8684606e6e4a739509c09124e91ce005))
12+
513
## [2.8.0-beta.0](https://github.com/twilio-labs/twilio-run/compare/v2.7.0...v2.8.0-beta.0) (2020-07-08)
614

715

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "twilio-run",
3-
"version": "2.8.0-beta.0",
3+
"version": "2.8.0-beta.1",
44
"bin": {
55
"twilio-functions": "./bin/twilio-run.js",
66
"twilio-run": "./bin/twilio-run.js"
@@ -38,7 +38,7 @@
3838
"author": "Dominik Kundel <dkundel@twilio.com>",
3939
"license": "MIT",
4040
"dependencies": {
41-
"@twilio-labs/serverless-api": "^3.1.0",
41+
"@twilio-labs/serverless-api": "^4.0.1",
4242
"@twilio-labs/serverless-runtime-types": "^1.1.7",
4343
"@types/express": "^4.17.0",
4444
"@types/inquirer": "^6.0.3",
@@ -96,6 +96,7 @@
9696
"@types/lodash.kebabcase": "^4.1.6",
9797
"@types/lodash.startcase": "^4.4.6",
9898
"@types/mock-fs": "^4.10.0",
99+
"@types/node": "^14.0.19",
99100
"@types/prompts": "^2.0.1",
100101
"@types/supertest": "^2.0.8",
101102
"@types/title": "^1.0.5",

src/checks/check-credentials.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ import { stripIndent } from 'common-tags';
22
import { logger } from '../utils/logger';
33

44
type ConfigWithCredentials = {
5-
accountSid?: string;
6-
authToken?: string;
5+
username?: string;
6+
password?: string;
77
};
88

99
export function checkConfigForCredentials(
1010
config: ConfigWithCredentials,
1111
shouldExit = true
1212
) {
13-
if (config.accountSid && config.authToken) {
13+
if (config.username && config.password) {
1414
return;
1515
}
1616

src/commands/activate.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
import {
2-
ActivateConfig,
3-
TwilioServerlessApiClient,
4-
} from '@twilio-labs/serverless-api';
1+
import { TwilioServerlessApiClient } from '@twilio-labs/serverless-api';
52
import { Ora } from 'ora';
63
import { Argv } from 'yargs';
74
import { checkConfigForCredentials } from '../checks/check-credentials';
8-
import { ActivateCliFlags, getConfigFromFlags } from '../config/activate';
5+
import {
6+
ActivateCliFlags,
7+
ActivateConfig,
8+
getConfigFromFlags,
9+
} from '../config/activate';
910
import { printActivateConfig, printActivateResult } from '../printers/activate';
1011
import {
1112
getDebugFunction,

src/commands/deploy.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
import {
2-
DeployLocalProjectConfig,
3-
TwilioServerlessApiClient,
4-
} from '@twilio-labs/serverless-api';
1+
import { TwilioServerlessApiClient } from '@twilio-labs/serverless-api';
52
import { stripIndent } from 'common-tags';
63
import { Ora } from 'ora';
74
import path from 'path';
85
import { Argv } from 'yargs';
96
import { checkConfigForCredentials } from '../checks/check-credentials';
107
import checkProjectStructure from '../checks/project-structure';
11-
import { DeployCliFlags, getConfigFromFlags } from '../config/deploy';
8+
import {
9+
DeployCliFlags,
10+
DeployLocalProjectConfig,
11+
getConfigFromFlags,
12+
} from '../config/deploy';
1213
import { printConfigInfo, printDeployedResources } from '../printers/deploy';
1314
import { HttpError, saveLatestDeploymentData } from '../serverless-api/utils';
1415
import {
@@ -117,8 +118,8 @@ export async function handler(
117118
config.cwd,
118119
serviceSid,
119120
buildSid,
120-
config.accountSid.startsWith('AC')
121-
? config.accountSid
121+
config.username.startsWith('AC')
122+
? config.username
122123
: externalCliOptions && externalCliOptions.accountSid
123124
);
124125
} catch (err) {

src/config/activate.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ import {
1616
} from './utils';
1717
import { mergeFlagsAndConfig } from './utils/mergeFlagsAndConfig';
1818

19-
type ActivateConfig = ApiActivateConfig & {
19+
export type ActivateConfig = ApiActivateConfig & {
2020
cwd: string;
21-
accountSid?: string;
22-
authToken?: string;
21+
username: string;
22+
password: string;
2323
};
2424

2525
export type ActivateCliFlags = Arguments<
@@ -76,8 +76,8 @@ export async function getConfigFromFlags(
7676

7777
return {
7878
cwd,
79-
accountSid,
80-
authToken,
79+
username: accountSid,
80+
password: authToken,
8181
serviceSid,
8282
force: flags.force,
8383
createEnvironment: flags.createEnvironment,

src/config/deploy.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DeployLocalProjectConfig } from '@twilio-labs/serverless-api';
1+
import { DeployLocalProjectConfig as ApiDeployLocalProjectConfig } from '@twilio-labs/serverless-api';
22
import path from 'path';
33
import { Arguments } from 'yargs';
44
import { cliInfo } from '../commands/deploy';
@@ -18,6 +18,11 @@ import {
1818
} from './utils';
1919
import { mergeFlagsAndConfig } from './utils/mergeFlagsAndConfig';
2020

21+
export type DeployLocalProjectConfig = ApiDeployLocalProjectConfig & {
22+
username: string;
23+
password: string;
24+
};
25+
2126
export type DeployCliFlags = Arguments<
2227
SharedFlagsWithCredentials & {
2328
serviceSid?: string;
@@ -101,8 +106,8 @@ export async function getConfigFromFlags(
101106
return {
102107
cwd,
103108
envPath,
104-
accountSid,
105-
authToken,
109+
username: accountSid,
110+
password: authToken,
106111
env,
107112
serviceSid,
108113
pkgJson,

src/config/list.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ import {
1919
import { mergeFlagsAndConfig } from './utils/mergeFlagsAndConfig';
2020

2121
export type ListConfig = ApiListConfig & {
22+
username: string;
23+
password: string;
2224
cwd: string;
2325
properties?: string[];
2426
extendedOutput: boolean;
@@ -78,8 +80,8 @@ export async function getConfigFromFlags(
7880

7981
return {
8082
cwd,
81-
accountSid,
82-
authToken,
83+
username: accountSid,
84+
password: authToken,
8385
serviceSid,
8486
serviceName,
8587
environment: flags.environment,

src/config/logs.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ import { mergeFlagsAndConfig } from './utils/mergeFlagsAndConfig';
1717

1818
export type LogsConfig = ClientConfig &
1919
ApiLogsConfig & {
20+
username: string;
21+
password: string;
2022
cwd: string;
21-
accountSid: string;
22-
authToken: string;
2323
properties?: string[];
2424
outputFormat?: string;
2525
};
@@ -72,8 +72,8 @@ export async function getConfigFromFlags(
7272

7373
return {
7474
cwd,
75-
accountSid,
76-
authToken,
75+
username: accountSid,
76+
password: authToken,
7777
environment,
7878
serviceSid,
7979
outputFormat,

src/printers/activate.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { ActivateConfig, ActivateResult } from '@twilio-labs/serverless-api';
1+
import { ActivateResult } from '@twilio-labs/serverless-api';
22
import { stripIndent } from 'common-tags';
3+
import { ActivateConfig } from '../config/activate';
34
import { logger } from '../utils/logger';
45
import { writeOutput } from '../utils/output';
56
import { getTwilioConsoleDeploymentUrl, redactPartOfString } from './utils';
@@ -8,8 +9,8 @@ import terminalLink = require('terminal-link');
89

910
export function printActivateConfig(config: ActivateConfig) {
1011
const message = chalk`
11-
{cyan.bold Account} ${config.accountSid}
12-
{cyan.bold Token} ${redactPartOfString(config.authToken)}
12+
{cyan.bold Account} ${config.username}
13+
{cyan.bold Token} ${redactPartOfString(config.password)}
1314
`;
1415
logger.info(stripIndent(message) + '\n');
1516
}

0 commit comments

Comments
 (0)