"pending" allocation status missing

[simonLeary42]

The docs describe an allocation status "pending":

Pending

This status currently provides no automation for any plugins. It can be used as part of a center's business process.

But I don't see this status in the dropdown.

Why is that?

[matthew-kusz]

A quick look in here shows it's missing from the list for AllocationStatusChoice when adding defaults so you'll have to add it yourself.

[simonLeary42]

Would a PR be welcome to add it to the list?

[matthew-kusz]

It seems like it should be included, but I'll wait for @dsajdak or @aebruno to weigh in on it.

[dsajdak]

Yes, feel free to add it. We added a "pending" status on our site though there's nothing automated or anything tied to use it in CF. I guess when I was documenting those statuses, I forgot.

[simonLeary42]

I only discovered it because I also wanted to add a "pending" status for when the money goes through for an allocation but the admin hasn't set it up yet. For allocation_openldap, I want to use this status to trigger the creation of an LDAP entry, which the admin needs in order to set up the storage quota.

[simonLeary42]

Actually, Approved might be more appropriate:

This status currently provides no automation for any plugins. It can be used as part of a center's business process. For example, your center may have a committee that reviews allocation requests prior to the system administrators activating them. This status could be used by the allocation request reviewers to mark it for the admins to activate.

[simonLeary42]

fixed by #816

#816 adds a FIXME comment in one place where it should be added, but I haven't confirmed that is the specific place that fixes this dropdown list

[simonLeary42]

For the record, Approved is also missing from the dropdown.

[simonLeary42]

I think it's this:

coldfront/coldfront/core/allocation/templates/allocation/allocation_detail.html

Line 82 in cefa1bd

{{ form.status }}

coldfront/coldfront/core/allocation/forms.py

Lines 72 to 74 in cefa1bd

	status = forms.ModelChoiceField(
	queryset=AllocationStatusChoice.objects.all().order_by(Lower("name")), empty_label=None
	)

Which means that it doesn't need to be added to any source code, it needs be added to the database, which has already been done in 43f9c4b. But if the records were created in that migration, why can't I see them?