chore: update flutter and remove animated emoji because it causes flicker on some setups (#1343)

Feichtmeier · web-flow · commit ce2e5af7b8d4 · 2025-07-30T18:06:51.000Z
Fixes #1258
diff --git a/.fvmrc b/.fvmrc
@@ -1,3 +1,3 @@
 {
-  "flutter": "3.32.7"
+  "flutter": "3.32.8"
 }
diff --git a/lib/app/view/musicpod.dart b/lib/app/view/musicpod.dart
@@ -30,24 +30,18 @@ class _MusicPodState extends State<MusicPod> {
   }
 
   @override
-  Widget build(BuildContext context) => ValueListenableBuilder(
-    valueListenable: appRestartNotifier,
-    builder: (context, key, child) {
-      return FutureBuilder(
-        key: key,
-        future: _allReady,
-        builder: (context, snapshot) => snapshot.hasError
-            ? SplashScreen(body: Center(child: Text(snapshot.error.toString())))
-            : snapshot.hasData
-            ? isLinux
-                  ? GtkApplication(
-                      onCommandLine: (args) =>
-                          di<PlayerService>().playPath(args.firstOrNull),
-                      child: const YaruMusicPodApp(),
-                    )
-                  : const MaterialMusicPodApp()
-            : const SplashScreen(),
-      );
-    },
+  Widget build(BuildContext context) => FutureBuilder(
+    future: _allReady,
+    builder: (context, snapshot) => snapshot.hasError
+        ? SplashScreen(body: Center(child: Text(snapshot.error.toString())))
+        : snapshot.hasData
+        ? isLinux
+              ? GtkApplication(
+                  onCommandLine: (args) =>
+                      di<PlayerService>().playPath(args.firstOrNull),
+                  child: const YaruMusicPodApp(),
+                )
+              : const MaterialMusicPodApp()
+        : const SplashScreen(),
   );
 }
diff --git a/lib/common/view/no_search_result_page.dart b/lib/common/view/no_search_result_page.dart
@@ -1,8 +1,8 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 
 import '../../extensions/build_context_x.dart';
 import '../../l10n/l10n.dart';
+import 'ui_constants.dart';
 
 class NoSearchResultPage extends StatelessWidget {
   const NoSearchResultPage({super.key, this.message, this.icon});
@@ -33,14 +33,13 @@ class NoSearchResultPage extends StatelessWidget {
             child: Column(
               mainAxisSize: MainAxisSize.min,
               children: [
-                icon ?? const AnimatedEmoji(AnimatedEmojis.thinkingFace),
-                const SizedBox(height: 10),
                 message ??
                     Text(
                       context.l10n.nothingFound,
                       style: style,
                       textAlign: TextAlign.center,
                     ),
+                const SizedBox(height: kLargestSpace),
               ],
             ),
           ),
diff --git a/lib/local_audio/view/album_page.dart b/lib/local_audio/view/album_page.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:collection/collection.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
@@ -53,7 +52,6 @@ class _AlbumPageState extends State<AlbumPage> {
         audioPageType: AudioPageType.album,
         audios: cachedAlbum,
         image: AlbumPageImage(audio: cachedAlbum.firstOrNull),
-        noSearchResultIcons: const AnimatedEmoji(AnimatedEmojis.bubbles),
         noSearchResultMessage: Text(context.l10n.albumNotFound),
         pageTitle: cachedAlbum.firstWhereOrNull((e) => e.album != null)?.album,
         pageSubTitle: cachedAlbum
@@ -88,7 +86,6 @@ class _AlbumPageState extends State<AlbumPage> {
           audioPageType: AudioPageType.album,
           audios: album,
           image: AlbumPageImage(audio: album.firstOrNull),
-          noSearchResultIcons: const AnimatedEmoji(AnimatedEmojis.bubbles),
           noSearchResultMessage: Text(context.l10n.albumNotFound),
           pageTitle: album.firstWhereOrNull((e) => e.album != null)?.album,
           pageSubTitle: album.firstWhereOrNull((e) => e.artist != null)?.artist,
diff --git a/lib/local_audio/view/local_audio_page.dart b/lib/local_audio/view/local_audio_page.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -86,7 +85,6 @@ class _LocalAudioPageState extends State<LocalAudioPage> {
         contentBuilder: (context, constraints) =>
             audios != null && audios.isEmpty
             ? SliverNoSearchResultPage(
-                icon: const AnimatedEmoji(AnimatedEmojis.bird),
                 message: Column(
                   mainAxisSize: MainAxisSize.min,
                   children: [
diff --git a/lib/playlists/view/liked_audio_page.dart b/lib/playlists/view/liked_audio_page.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -47,7 +46,6 @@ class _LikedAudioPageState extends State<LikedAudioPage> {
         pageId: text,
       ),
       noSearchResultMessage: Text(context.l10n.likedSongsSubtitle),
-      noSearchResultIcons: const AnimatedEmoji(AnimatedEmojis.twoHearts),
       audios: _likedAudios,
       audioPageType: AudioPageType.likedAudio,
       pageId: PageIDs.likedAudios,
diff --git a/lib/podcasts/view/podcasts_collection_body.dart b/lib/podcasts/view/podcasts_collection_body.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -89,7 +88,6 @@ class PodcastsCollectionBody extends StatelessWidget with WatchItMixin {
           ? SliverLoadingGrid(limit: subsLength)
           : (subsLength == 0)
           ? SliverNoSearchResultPage(
-              icon: const AnimatedEmoji(AnimatedEmojis.faceInClouds),
               message: Column(
                 mainAxisSize: MainAxisSize.min,
                 children: [
diff --git a/lib/radio/view/favorite_radio_tags_grid.dart b/lib/radio/view/favorite_radio_tags_grid.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:radio_browser_api/radio_browser_api.dart';
 import 'package:watch_it/watch_it.dart';
@@ -36,7 +35,6 @@ class FavoriteRadioTagsGrid extends StatelessWidget with WatchItMixin {
             const OpenRadioSearchButton(),
           ],
         ),
-        icon: const AnimatedEmoji(AnimatedEmojis.glowingStar),
       );
     }
 
diff --git a/lib/radio/view/radio_history_list.dart b/lib/radio/view/radio_history_list.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -34,7 +33,6 @@ class RadioHistoryList extends StatelessWidget with WatchItMixin {
 
     if (length == 0) {
       return NoSearchResultPage(
-        icon: emptyIcon ?? const AnimatedEmoji(AnimatedEmojis.crystalBall),
         message: emptyMessage ?? Text(context.l10n.emptyHearingHistory),
       );
     }
@@ -102,7 +100,6 @@ class SliverRadioHistoryList extends StatelessWidget with WatchItMixin {
     if (length == 0) {
       return SliverToBoxAdapter(
         child: NoSearchResultPage(
-          icon: emptyIcon ?? const AnimatedEmoji(AnimatedEmojis.crystalBall),
           message: emptyMessage ?? Text(context.l10n.emptyHearingHistory),
         ),
       );
diff --git a/lib/radio/view/starred_stations_grid.dart b/lib/radio/view/starred_stations_grid.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -38,7 +37,6 @@ class StarredStationsGrid extends StatelessWidget with WatchItMixin {
             const OpenRadioSearchButton(),
           ],
         ),
-        icon: const AnimatedEmoji(AnimatedEmojis.glowingStar),
       );
     }
 
diff --git a/lib/radio/view/station_page.dart b/lib/radio/view/station_page.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -90,7 +89,6 @@ class _StationPageState extends State<StationPage> {
         builder: (context, snapshot) {
           if (snapshot.hasError) {
             return NoSearchResultPage(
-              icon: const AnimatedEmoji(AnimatedEmojis.skull),
               message: Text(context.l10n.stationNotFound),
             );
           }
diff --git a/lib/search/view/sliver_local_search_results.dart b/lib/search/view/sliver_local_search_results.dart
@@ -1,5 +1,3 @@
-import 'package:animated_emoji/emoji.dart';
-import 'package:animated_emoji/emojis.g.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -65,10 +63,7 @@ class _SliverLocalSearchResultState extends State<SliverLocalSearchResult> {
     final searchQuery = watchPropertyValue((SearchModel m) => m.searchQuery);
 
     if (searchQuery == null || searchQuery.isEmpty == true) {
-      return SliverNoSearchResultPage(
-        icon: const AnimatedEmoji(AnimatedEmojis.drum),
-        message: Text(context.l10n.search),
-      );
+      return SliverNoSearchResultPage(message: Text(context.l10n.search));
     }
 
     return LocalAudioBody(
diff --git a/lib/search/view/sliver_podcast_search_results.dart b/lib/search/view/sliver_podcast_search_results.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -56,11 +55,6 @@ class _SliverPodcastSearchResultsState
 
     if (searchResultItems == null || searchResultItems.isEmpty) {
       return SliverNoSearchResultPage(
-        icon: loading
-            ? const SizedBox.shrink()
-            : searchResultItems == null
-            ? const AnimatedEmoji(AnimatedEmojis.drum)
-            : const AnimatedEmoji(AnimatedEmojis.babyChick),
         message: loading
             ? const Progress()
             : Text(
diff --git a/lib/search/view/sliver_radio_search_results.dart b/lib/search/view/sliver_radio_search_results.dart
@@ -1,4 +1,3 @@
-import 'package:animated_emoji/animated_emoji.dart';
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
@@ -47,15 +46,13 @@ class SliverRadioSearchResults extends StatelessWidget with WatchItMixin {
     if (radioSearchResult == null ||
         (searchQuery?.isEmpty == true && radioSearchResult.isEmpty == true)) {
       return SliverNoSearchResultPage(
-        icon: const AnimatedEmoji(AnimatedEmojis.drum),
         message: Text(
           '${context.l10n.search} ${searchType.localize(context.l10n)}',
         ),
       );
     }
     if (radioSearchResult.isEmpty && !loading) {
       return SliverNoSearchResultPage(
-        icon: const AnimatedEmoji(AnimatedEmojis.rabbit),
         message: Text(context.l10n.noStationFound),
       );
     }
diff --git a/pubspec.lock b/pubspec.lock
@@ -13,18 +13,10 @@ packages:
     dependency: transitive
     description:
       name: analyzer
-      sha256: b1ade5707ab7a90dfd519eaac78a7184341d19adb6096c68d499b59c7c6cf880
+      sha256: "974859dc0ff5f37bc4313244b3218c791810d03ab3470a579580279ba971a48d"
       url: "https://pub.dev"
     source: hosted
-    version: "7.7.0"
-  animated_emoji:
-    dependency: "direct main"
-    description:
-      name: animated_emoji
-      sha256: "2876d590db470baf6e660df125bdbe889eade7df6c0e7d79c56ad2fcbf5af890"
-      url: "https://pub.dev"
-    source: hosted
-    version: "3.2.1"
+    version: "7.7.1"
   animated_vector:
     dependency: transitive
     description:
@@ -150,10 +142,10 @@ packages:
     dependency: transitive
     description:
       name: build
-      sha256: "51dc711996cbf609b90cbe5b335bbce83143875a9d58e4b5c6d3c4f684d3dda7"
+      sha256: "7d95cbbb1526ab5ae977df9b4cc660963b9b27f6d1075c0b34653868911385e4"
       url: "https://pub.dev"
     source: hosted
-    version: "2.5.4"
+    version: "3.0.0"
   build_cli_annotations:
     dependency: transitive
     description:
@@ -182,26 +174,26 @@ packages:
     dependency: transitive
     description:
       name: build_resolvers
-      sha256: ee4257b3f20c0c90e72ed2b57ad637f694ccba48839a821e87db762548c22a62
+      sha256: "38c9c339333a09b090a638849a4c56e70a404c6bdd3b511493addfbc113b60c2"
       url: "https://pub.dev"
     source: hosted
-    version: "2.5.4"
+    version: "3.0.0"
   build_runner:
     dependency: "direct dev"
     description:
       name: build_runner
-      sha256: "382a4d649addbfb7ba71a3631df0ec6a45d5ab9b098638144faf27f02778eb53"
+      sha256: b971d4a1c789eba7be3e6fe6ce5e5b50fd3719e3cb485b3fad6d04358304351d
       url: "https://pub.dev"
     source: hosted
-    version: "2.5.4"
+    version: "2.6.0"
   build_runner_core:
     dependency: transitive
     description:
       name: build_runner_core
-      sha256: "85fbbb1036d576d966332a3f5ce83f2ce66a40bea1a94ad2d5fc29a19a0d3792"
+      sha256: c04e612ca801cd0928ccdb891c263a2b1391cb27940a5ea5afcf9ba894de5d62
       url: "https://pub.dev"
     source: hosted
-    version: "9.1.2"
+    version: "9.2.0"
   built_collection:
     dependency: transitive
     description:
@@ -862,14 +854,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.3.0"
-  lottie:
-    dependency: transitive
-    description:
-      name: lottie
-      sha256: c5fa04a80a620066c15cf19cc44773e19e9b38e989ff23ea32e5903ef1015950
-      url: "https://pub.dev"
-    source: hosted
-    version: "3.3.1"
   m3u_parser_nullsafe:
     dependency: "direct main"
     description:
@@ -997,10 +981,10 @@ packages:
     dependency: "direct main"
     description:
       name: mockito
-      sha256: "4546eac99e8967ea91bae633d2ca7698181d008e95fa4627330cf903d573277a"
+      sha256: "2314cbe9165bcd16106513df9cf3c3224713087f09723b128928dc11a4379f99"
       url: "https://pub.dev"
     source: hosted
-    version: "5.4.6"
+    version: "5.5.0"
   nm:
     dependency: transitive
     description:
@@ -1475,10 +1459,10 @@ packages:
     dependency: transitive
     description:
       name: source_gen
-      sha256: "35c8150ece9e8c8d263337a265153c3329667640850b9304861faea59fc98f6b"
+      sha256: fc787b1f89ceac9580c3616f899c9a447413cbdac1df071302127764c023a134
       url: "https://pub.dev"
     source: hosted
-    version: "2.0.0"
+    version: "3.0.0"
   source_span:
     dependency: transitive
     description:
@@ -1515,10 +1499,10 @@ packages:
     dependency: transitive
     description:
       name: sqflite_common
-      sha256: "84731e8bfd8303a3389903e01fb2141b6e59b5973cacbb0929021df08dddbe8b"
+      sha256: "6ef422a4525ecc601db6c0a2233ff448c731307906e92cabc9ba292afaae16a6"
       url: "https://pub.dev"
     source: hosted
-    version: "2.5.5"
+    version: "2.5.6"
   sqflite_darwin:
     dependency: transitive
     description:
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -8,7 +8,6 @@ environment:
   sdk: ">=3.8.0 <4.0.0"
 
 dependencies:
-  animated_emoji: ^3.2.1
   audio_metadata_reader: ^1.4.2
   audio_service: ^0.18.12
   audio_service_mpris:

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "flutter": "3.32.7"`
	`2`	`+ "flutter": "3.32.8"`
`3`	`3`	`}`