#6 Move from pedantic to lints package and fix issues raised by the analyser.

Author: amugofjava

CHANGELOG.md

@@ -2,7 +2,8 @@
 
 # 1.0.10
 
-* Added Thumbnail as a Media Group property
+* BREAKING CHANGE: All enums corrected to camel-case to fit in with current lint rules.
+* Added Thumbnail as a Media Group property (@michael-yarzebinski).
 
 # 1.0.9
 

analysis_options.yaml

@@ -1,11 +1 @@
-include: package:pedantic/analysis_options.yaml
-
-linter:
-  rules:
-    avoid_print: true
-    cancel_subscriptions: true
-    prefer_single_quotes: true
-    prefer_const_constructors: true
-    prefer_const_declarations: true
-    require_trailing_commas: true
-    use_super_parameters: true
+include: package:lints/recommended.yaml

lib/domain/dart_rss.dart

@@ -27,10 +27,10 @@ extension SafeParseDateTime on DateTime {
 }
 
 enum RssVersion {
-  RSS1,
-  RSS2,
-  Atom,
-  Unknown,
+  rss1,
+  rss2,
+  atom,
+  unknown,
 }
 
 class WebFeed {
@@ -49,16 +49,16 @@ class WebFeed {
   static WebFeed fromXmlString(String xmlString) {
     final rssVersion = detectRssVersion(xmlString);
     switch (rssVersion) {
-      case RssVersion.RSS1:
+      case RssVersion.rss1:
         final rss1Feed = Rss1Feed.parse(xmlString);
         return WebFeed.fromRss1(rss1Feed);
-      case RssVersion.RSS2:
+      case RssVersion.rss2:
         final rss2Feed = RssFeed.parse(xmlString);
         return WebFeed.fromRss2(rss2Feed);
-      case RssVersion.Atom:
+      case RssVersion.atom:
         final atomFeed = AtomFeed.parse(xmlString);
         return WebFeed.fromAtom(atomFeed);
-      case RssVersion.Unknown:
+      case RssVersion.unknown:
         throw Error.safeToString(
           'Invalid XML String? We cannot detect RSS/Atom version.',
         );
@@ -144,13 +144,13 @@ class WebFeed {
         : feedRefs.first.getAttribute('xmlns')?.toLowerCase().contains('atom');
 
     if (rdfRefs.isNotEmpty) {
-      return RssVersion.RSS1;
+      return RssVersion.rss1;
     } else if (rssRefs.isNotEmpty && ver != null && ver) {
-      return RssVersion.RSS2;
+      return RssVersion.rss2;
     } else if (feedRefs.isNotEmpty && xmlns != null && xmlns) {
-      return RssVersion.Atom;
+      return RssVersion.atom;
     }
-    return RssVersion.Unknown;
+    return RssVersion.unknown;
   }
 }
 

lib/domain/rss1_feed.dart

@@ -6,11 +6,11 @@ import 'package:rss_dart/util/helpers.dart';
 import 'package:xml/xml.dart';
 
 enum UpdatePeriod {
-  Hourly,
-  Daily,
-  Weekly,
-  Monthly,
-  Yearly,
+  hourly,
+  daily,
+  weekly,
+  monthly,
+  yearly,
 }
 
 class Rss1Feed {
@@ -39,15 +39,15 @@ class Rss1Feed {
   static UpdatePeriod? _parseUpdatePeriod(String? updatePeriodString) {
     switch (updatePeriodString) {
       case 'hourly':
-        return UpdatePeriod.Hourly;
+        return UpdatePeriod.hourly;
       case 'daily':
-        return UpdatePeriod.Daily;
+        return UpdatePeriod.daily;
       case 'weekly':
-        return UpdatePeriod.Weekly;
+        return UpdatePeriod.weekly;
       case 'monthly':
-        return UpdatePeriod.Monthly;
+        return UpdatePeriod.monthly;
       case 'yearly':
-        return UpdatePeriod.Yearly;
+        return UpdatePeriod.yearly;
       default:
         return null;
     }

pubspec.yaml

@@ -12,4 +12,4 @@ dependencies:
 
 dev_dependencies:
   test: ^1.16.4
-  pedantic: ^1.10.0
+  lints: ^4.0.0

test/rss1_test.dart

@@ -37,7 +37,7 @@ void main() {
     expect(feed.link, 'http://meerkat.oreillynet.com');
     expect(feed.description, 'Meerkat: An Open Wire Service');
 
-    expect(feed.updatePeriod, UpdatePeriod.Hourly);
+    expect(feed.updatePeriod, UpdatePeriod.hourly);
     expect(feed.updateFrequency, 2);
     expect(feed.updateBase, DateTime.parse('2000-01-01T12:00+00:00'));
   });

test/rss_test.dart

@@ -98,7 +98,7 @@ void main() {
 
     expect(
       feed.items.first.content!.value,
-      '<img alt="unit test image" width=\"1000\" height=\"690\" src=\"https://test.com/image_link\"/> Test content<br />',
+      '<img alt="unit test image" width="1000" height="690" src="https://test.com/image_link"/> Test content<br />',
     );
     expect(
       feed.items.first.content!.images.first,
@@ -439,14 +439,14 @@ void main() {
     expect(feed.podcastIndex?.value![0]!.recipients![0]!.name, 'podcaster');
     expect(feed.podcastIndex?.value![0]!.recipients![0]!.type, 'node');
     expect(feed.podcastIndex?.value![0]!.recipients![0]!.address,
-        'ABCDEFGHIJLKMNOPQRSTUVWXYZ');
+        'ABCDEFGHIJLKMNOPQRSTUVWXYZ',);
     expect(feed.podcastIndex?.value![0]!.recipients![0]!.split, 99);
 
     expect(
-        feed.podcastIndex?.value![0]!.recipients![1]!.name, 'hosting company');
+        feed.podcastIndex?.value![0]!.recipients![1]!.name, 'hosting company',);
     expect(feed.podcastIndex?.value![0]!.recipients![1]!.type, 'node');
     expect(feed.podcastIndex?.value![0]!.recipients![1]!.address,
-        'abcdefghijklmnopqrstuvwxyz');
+        'abcdefghijklmnopqrstuvwxyz',);
     expect(feed.podcastIndex?.value![0]!.recipients![1]!.split, 1);
 
     expect(feed.podcastIndex!.guid, '20a14457-0993-49b8-a37a-18384e7f91f8');
@@ -469,7 +469,7 @@ void main() {
     expect(chapters1?.type, 'application/json');
 
     expect(item1.podcastIndex!.license!.url,
-        'https://www.mytestlicense.org/lic.html');
+        'https://www.mytestlicense.org/lic.html',);
     expect(item1.podcastIndex!.license!.license, 'my-test-license-v1');
 
     expect(soundbite1.length, 1);

test/webfeed_test.dart

@@ -27,17 +27,17 @@ void main() {
 
     test('it can detect Atom feed.', () {
       final version = WebFeed.detectRssVersion(atomXmlString);
-      expect(version, RssVersion.Atom);
+      expect(version, RssVersion.atom);
     });
 
     test('it can detect RSS1.0 feed.', () {
       final version = WebFeed.detectRssVersion(rss1XmlString);
-      expect(version, RssVersion.RSS1);
+      expect(version, RssVersion.rss1);
     });
 
     test('it can detect RSS2.0 feed.', () {
       final version = WebFeed.detectRssVersion(rss2XmlString);
-      expect(version, RssVersion.RSS2);
+      expect(version, RssVersion.rss2);
     });
 
     test('it can parse Atom feed.', () {