fix: Fix boolean options won't update to false. #96

jaywcjlove · jaywcjlove · commit a9b71e72848d · 2021-07-02T01:44:56.000+08:00
diff --git a/src/index.js b/src/index.js
@@ -47,7 +47,7 @@ function ReactCodeMirror(props = {}, ref) {
         opt.mode = mode.mime;
       }
       Object.keys(opt).forEach((name) => {
-        if (opt[name] && JSON.stringify(opt[name])) {
+        if ((opt[name] || opt[name] === false) && JSON.stringify(opt[name])) {
           instance.setOption(name, opt[name]);
         }
       });

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ function ReactCodeMirror(props = {}, ref) {`
`47`	`47`	`opt.mode = mode.mime;`
`48`	`48`	`}`
`49`	`49`	`Object.keys(opt).forEach((name) => {`
`50`		`- if (opt[name] && JSON.stringify(opt[name])) {`
	`50`	`+ if ((opt[name] \|\| opt[name] === false) && JSON.stringify(opt[name])) {`
`51`	`51`	`instance.setOption(name, opt[name]);`
`52`	`52`	`}`
`53`	`53`	`});`