fix(reactant-module): fix @action check result value in dev mode

Author: unadlib

packages/reactant-module/src/decorators/action.ts

@@ -76,12 +76,22 @@ const action = (
             Record<string, unknown>
           >(lastState, (draftState) => {
             stagedState = draftState;
-            fn.apply(this, args);
+            const result = fn.apply(this, args);
+            if (__DEV__ && result !== undefined) {
+              throw new Error(
+                `The return value of the method '${key}' is not allowed.`
+              );
+            }
           });
         } else {
           state = produce<Record<string, unknown>>(lastState, (draftState) => {
             stagedState = draftState;
-            fn.apply(this, args);
+            const result = fn.apply(this, args);
+            if (__DEV__ && result !== undefined) {
+              throw new Error(
+                `The return value of the method '${key}' is not allowed.`
+              );
+            }
           });
         }
         stagedState = undefined;

packages/reactant-module/test/decorators/action.test.ts

@@ -30,6 +30,16 @@ describe('@action', () => {
         const { count } = this;
         this.count = count;
       }
+
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
+      @action
+      unexpectedChange(): any {
+        this.count = 0;
+        return this.returnValue;
+      }
+
+      returnValue: any = 0;
     }
     const ServiceIdentifiers = new Map();
     const modules = [Counter];
@@ -71,6 +81,30 @@ describe('@action', () => {
       `There are no state updates to method 'counter.noChange'`
     );
     warn.mockReset();
+
+    for (const value of [
+      0,
+      1,
+      null,
+      true,
+      false,
+      new Promise(() => {
+        //
+      }),
+      function a() {
+        //
+      },
+      {},
+      [],
+      Symbol(''),
+    ]) {
+      expect(() => {
+        counter.returnValue = value;
+        counter.unexpectedChange();
+      }).toThrowError(
+        /The return value of the method 'unexpectedChange' is not allowed./
+      );
+    }
   });
 
   test('enable `autoFreeze` in devOptions', () => {