#175 simplify

Author: Eugene Tupikov

CHANGELOG.md

@@ -6,7 +6,7 @@ Yii2 multiple input change log
 - #215 collect all js script that has to be evaluate when add new row (not only from " on ready" section)
 - #198 introduce the option `theme` to disable all bootstrap css classes
 - #197 explicitly set tabindex for all inputs
-- #175 option `generalErrorPosition` to enable displaying of general error message 
+- #175 option `showGeneralError` to enable displaying of general error message 
 
 2.16.0
 ======

examples/views/multiple-input.php

@@ -53,7 +53,7 @@
     'max' => 4,
     'sortable' => true,
     'allowEmptyList' => true,
-    'generalErrorPosition' => 'top',
+    'showGeneralError' => true,
     'rowOptions' => function($model) {
         $options = [];
 

src/MultipleInput.php

@@ -37,9 +37,6 @@ class MultipleInput extends InputWidget
 
     const ICONS_SOURCE_GLYPHICONS  = 'glyphicons';
     const ICONS_SOURCE_FONTAWESOME = 'fa';
-    
-    const GENERAL_ERROR_POS_TOP     = 'top';
-    const GENERAL_ERROR_POS_BOTTOM  = 'bottom';
 
     /**
      * @var ActiveRecordInterface[]|array[] input data
@@ -208,16 +205,10 @@ class MultipleInput extends InputWidget
      */
     public $theme = self::THEME_BS;
 
-    /**
-     * @var string|null set a position of generic error message (when you set an error for generic field instead of particular input)
-     * If set to null no generic error message will be shown. 
-     */
-    public $generalErrorPosition;
-
     /**
      * @var bool
      */
-    private $showGeneralError = false;
+    public $showGeneralError = false;
 
     /**
      * Initialization.
@@ -230,14 +221,8 @@ public function init()
             throw new InvalidConfigException('Property "form" must be an instance of yii\widgets\ActiveForm');
         }
 
-        $this->showGeneralError = $this->generalErrorPosition !== null && !$this->isEmbedded && $this->field;
-
-        if ($this->showGeneralError) {
-            if ($this->generalErrorPosition === self::GENERAL_ERROR_POS_BOTTOM) {
-                $this->field->template = "{input}\n{error}";
-            } else {
-                $this->field->template = "{error}\n{input}";
-            }
+        if ($this->showGeneralError && $this->field === null) {
+            $this->showGeneralError = false;
         }
 
         $this->guessColumns();