Merge pull request #22 from aivis/set-limits-to-data-collectors

set limits to data collectors

Author: aivis

src/Understand/UnderstandLaravel5/ExceptionEncoder.php

@@ -13,6 +13,19 @@ class ExceptionEncoder
      */
     protected $projectRoot;
 
+    /**
+     * @var int
+     */
+    protected $stackTraceLimit = 100;
+
+    /**
+     * @param integer $limit
+     */
+    public function setStackTraceLimit($limit)
+    {
+        $this->stackTraceLimit = $limit;
+    }
+
     /**
      * @param string $projectRoot
      */
@@ -82,7 +95,7 @@ public function setCurrentStackTrace(array $errorLog)
      */
     protected function getCurrentStackTrace()
     {
-        $stackTrace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 100);
+        $stackTrace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, $this->stackTraceLimit);
         $vendorExcluded = false;
 
         foreach($stackTrace as $index => $trace)
@@ -126,6 +139,7 @@ protected function getCurrentStackTrace()
     public function stackTraceToArray(array $stackTrace, $topFile = null, $topLine = null)
     {
         $stack = [];
+        $counter = 0;
 
         foreach ($stackTrace as $trace)
         {
@@ -151,6 +165,13 @@ public function stackTraceToArray(array $stackTrace, $topFile = null, $topLine =
                 'line' => $this->getStackTraceLine($trace),
                 'code' => $this->getCode($this->getStackTraceFile($trace), $this->getStackTraceLine($trace)),
             ];
+
+            $counter++;
+
+            if ($counter >= $this->stackTraceLimit)
+            {
+                break;
+            }
         }
 
         return $stack;

src/Understand/UnderstandLaravel5/FieldProvider.php

@@ -256,10 +256,17 @@ protected function getLaravelVersion()
      */
     protected function getSqlQueries()
     {
-        if ($this->dataCollector)
+        if ( ! $this->dataCollector)
         {
-            return $this->dataCollector->getByKey('sql_queries');
+            return [];
         }
+
+        if ($queries = $this->dataCollector->getByKey('sql_queries'))
+        {
+            return array_slice($queries, -500);
+        }
+
+        return [];
     }
 
     /**

tests/ExceptionEncoderTest.php

@@ -100,4 +100,21 @@ protected function assertIncompleteClassStackTrace($exception, $index)
 
         $this->assertSame('object(__PHP_Incomplete_Class)', $stackTraceArray[$index]['args'][0]);
     }
+
+    public function testStackTraceLimit()
+    {
+        $exception = new \DomainException;
+
+        $encoder = new Understand\UnderstandLaravel5\ExceptionEncoder();
+
+        $originalStackTrace = $exception->getTrace();
+        $stackTraceArray = $encoder->stackTraceToArray($originalStackTrace);
+
+        $this->assertTrue(count($stackTraceArray) > 2);
+
+        $encoder->setStackTraceLimit(2);
+        $stackTraceArray2 = $encoder->stackTraceToArray($originalStackTrace);
+
+        $this->assertTrue(count($stackTraceArray2) === 2);
+    }
 }

tests/FieldProviderTest.php

@@ -70,4 +70,13 @@ public function testSentryGetUser()
 
         $this->assertSame($user->id, $currentUserId);
     }
+
+    public function testQueryCount()
+    {
+        $this->app['understand.dataCollector']->set('sql_queries', range(1, 1000));
+
+        $queries = $this->app['understand.fieldProvider']->getSqlQueries();
+
+        $this->assertCount(500, $queries);
+    }
 }