Skip to content

Commit 7c4946a

Browse files
committed
refactor(devti): improve JDK version detection logic
- Update JDK detection to use sdkType.name comparison instead of instanceOf - Remove unused import of JavaSdk class
1 parent 88ca1b7 commit 7c4946a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

core/src/main/kotlin/cc/unitmesh/devti/sketch/run/ProcessExecutor.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import com.intellij.openapi.progress.Task
2727
import com.intellij.openapi.progress.impl.BackgroundableProcessIndicator
2828
import com.intellij.openapi.project.Project
2929
import com.intellij.openapi.project.ProjectManager
30-
import com.intellij.openapi.projectRoots.JavaSdk
3130
import com.intellij.openapi.projectRoots.ProjectJdkTable
3231
import com.intellij.openapi.projectRoots.Sdk
3332
import com.intellij.openapi.roots.ProjectRootManager
@@ -194,14 +193,14 @@ class ProcessExecutor(val project: Project) {
194193
companion object {
195194
fun getJdkVersion(project: Project): String? {
196195
val projectSdk = ProjectRootManager.getInstance(project).projectSdk
197-
if (projectSdk != null && projectSdk.sdkType is JavaSdk) {
196+
if (projectSdk != null && projectSdk.sdkType.name == "JavaSDK") {
198197
return projectSdk.homePath
199198
}
200199

201200
val projectJdkTable = ProjectJdkTable.getInstance()
202201
if (projectJdkTable.allJdks.isNotEmpty()) {
203202
for (jdk in projectJdkTable.allJdks) {
204-
if (jdk.sdkType is JavaSdk) {
203+
if (jdk.sdkType.name == "JavaSDK") {
205204
return jdk.homePath
206205
}
207206
}

0 commit comments

Comments
 (0)