Return driver object only when valid (#93)

* Return driver object only when valid

Without this, a driver that failed the sanity check could be returned. This leads to attempting to use it when checking URLs, which led to avoidable failures.

Fixes #92

Author: mabraham

CHANGELOG.md

@@ -12,6 +12,7 @@ and **Merged pull requests**. Critical items to know are:
 Referenced versions in headers are tagged on Github, in parentheses are for pypi.
 
 ## [vxx](https://github.com/urlstechie/urlschecker-python/tree/master) (master)
+ - avoid using web driver when it doesn't work (0.0.36)
  - allow variable to skip checking certificates (0.0.35)
  - switch back to pypi release of fake-useragent (0.0.34)
  - preparing to install from git for fake-useragent (0.0.33)

urlchecker/core/urlproc.py

@@ -155,9 +155,10 @@ def get_driver(self, port: Optional[int] = None, timeout: Optional[int] = 5):
 
             driver = WebDriver(port=port, timeout=timeout)
 
-            # Do a sanity check of the driver
+            # Do a sanity check of the default driver
             driver.check("https://google.com")
         except:
+            driver = None
             logger.warning(
                 "Issue with driver, results will be improved if you have it! Please match your version from https://googlechromelabs.github.io/chrome-for-testing"
             )

urlchecker/version.py

@@ -7,7 +7,7 @@
 
 """
 
-__version__ = "0.0.35"
+__version__ = "0.0.36"
 AUTHOR = "Ayoub Malek, Vanessa Sochat"
 AUTHOR_EMAIL = "superkogito@gmail.com, vsochat@stanford.edu"
 NAME = "urlchecker"