Skip to content

Commit 3f62795

Browse files
committed
fix: eslint fixes
1 parent 83208f9 commit 3f62795

File tree

6 files changed

+21
-16
lines changed

6 files changed

+21
-16
lines changed

eslint.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default typescriptEslint.config(
1212
"**/dist",
1313
"assets/",
1414
"src/dev.ts",
15+
"tests/**/*",
1516
],
1617
},
1718
{
@@ -28,7 +29,7 @@ export default typescriptEslint.config(
2829
parserOptions: { parser: typescriptEslint.parser },
2930
},
3031
rules: {
31-
"@typescript-eslint/no-explicit-any": "off", // Allow the use of `any`
32+
"@typescript-eslint/no-explicit-any": "warn", // Allow the use of `any`
3233
"@typescript-eslint/no-unused-vars": [
3334
"error",
3435
{

src/components/DataTable.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export default defineComponent({
7777

7878
data: () => {
7979
return reactive({
80-
dataFetched: [] as Column[],
80+
dataFetched: [] as Data,
8181
dataFetchedLinks: [] as any[],
8282
currentPage: 1,
8383
currentPerPage: 10,
@@ -182,7 +182,10 @@ export default defineComponent({
182182
return data
183183
}
184184

185-
return sortDataByColumns(data as Data, columnsBeingSorted)
185+
return sortDataByColumns(
186+
data as unknown as Data,
187+
columnsBeingSorted
188+
)
186189
},
187190

188191
/**
@@ -532,7 +535,7 @@ export default defineComponent({
532535
/**
533536
* Indicates if a page is valid
534537
*/
535-
isValidPage(page: any): boolean {
538+
isValidPage(page: number | string): boolean {
536539
return (
537540
typeof page === "number" &&
538541
page <= this.numberOfPages &&
@@ -586,15 +589,15 @@ export default defineComponent({
586589
// so, mark it as sorted in ascending mode
587590
if (column.sortingMode === SORTING_MODE.NONE) {
588591
column.sortingMode = SORTING_MODE.ASC
589-
this.columnsBeingSorted = [column] as any
592+
this.columnsBeingSorted = [column]
590593
return
591594
}
592595

593596
// the column is being sorted in ascending mode
594597
// so, mark it as sorted in descending mode
595598
if (column.sortingMode === SORTING_MODE.ASC) {
596599
column.sortingMode = SORTING_MODE.DESC
597-
this.columnsBeingSorted = [column] as any
600+
this.columnsBeingSorted = [column]
598601
return
599602
}
600603

@@ -654,11 +657,11 @@ export default defineComponent({
654657
/**
655658
* Set the current page being displayed
656659
*/
657-
setPage(value: any) {
660+
setPage(value: number | string) {
658661
if (!this.isValidPage(value)) {
659662
return
660663
}
661-
this.currentPage = value
664+
this.currentPage = Number(value)
662665
this.updateData()
663666
},
664667

src/components/Table/Table.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ export default defineComponent({
44
name: "VdtTable",
55
props: {
66
tableClass: String,
7-
columns: Array as () => any,
7+
columns: Array as () => any[],
88
data: Array,
9-
dataDisplayed: Array as () => any,
10-
dataFiltered: Array as () => any,
9+
dataDisplayed: Array as () => any[],
10+
dataFiltered: Array as () => any[],
1111
emptyTableText: String,
1212
footerComponent: [Object, String],
1313
isEmpty: Boolean,

src/components/Table/Table.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
<!-- NON-EMPTY BODY -->
7272
<tr
7373
v-for="data in dataDisplayed"
74-
:key="data._key"
74+
:key="(data._key)"
7575
>
7676
<td
7777
v-for="(column, j) in columns"

src/types.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,5 @@ export type LanguageDictVal = string
4545
export type LanguageDict = Record<LanguageDictKey, LanguageDictVal>
4646
export type Translation = Record<LanguageName, LanguageDict>
4747

48-
export type Cell = { [key: string]: any }
48+
export type Cell = { [key: string]: [String, Number, Array, Object] }
4949
export type Data = Cell[]

src/utils.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ export function toTitleCase(str: string): string {
2121
export function stringReplaceFromArray(
2222
target: string,
2323
searchValues: string[],
24-
replacements: any[]
24+
replacements: (string | number)[]
2525
): string {
2626
for (let i = 0; i < searchValues.length; i++) {
27-
target = target.replace(searchValues[i], replacements[i])
27+
target = target.replace(searchValues[i], "" + replacements[i])
2828
}
2929
return target
3030
}
@@ -147,7 +147,8 @@ export function searchStringColumn(
147147
search: string,
148148
key: string
149149
): boolean {
150-
return (data[key] || "").toLowerCase().includes(search.toLowerCase())
150+
return ((data[key] || "") as unknown as string)
151+
.toLowerCase().includes(search.toLowerCase())
151152
}
152153

153154
// Performs search on numeric values

0 commit comments

Comments
 (0)