Skip to content

CMakeList doesnt support adaptivecpp as a SCYL Implementation, contrary to docs #711

@LowPolygons

Description

@LowPolygons

Very simply, the provided link to build instructions takes you to a website which recommends the cmake flag

DONEMATH_SYCL_IMPLEMENTATION=adaptivecpp (https://uxlfoundation.github.io/oneMath/building_the_project_with_adaptivecpp.html)

This fails to compile, and checking the CMakeLists file in the current version reveals no support for the recommended 'adaptivecpp'

  if(ONEMATH_SYCL_IMPLEMENTATION)
    string( TOLOWER "${ONEMATH_SYCL_IMPLEMENTATION}" ONEMATH_SYCL_IMPLEMENTATION)
    if (ONEMATH_SYCL_IMPLEMENTATION STREQUAL "hipsycl")
      message(STATUS "Looking for hipSYCL")
      find_package(hipSYCL CONFIG REQUIRED)
      set(USE_ADD_SYCL_TO_TARGET_INTEGRATION true)
      set (CMAKE_CXX_STANDARD 17)
      add_library(ONEMATH::SYCL::SYCL INTERFACE IMPORTED)
    elseif(ONEMATH_SYCL_IMPLEMENTATION STREQUAL "dpc++")
      message(STATUS "Looking for dpc++")
      set(USE_ADD_SYCL_TO_TARGET_INTEGRATION false)
      find_package(Compiler REQUIRED)
    else()
      message(FATAL_ERROR "SYCL implementation ${ONEMATH_SYCL_IMPLEMENTATION} is not known")
    endif()
  else()
    message(STATUS "Looking for dpc++")
    set(USE_ADD_SYCL_TO_TARGET_INTEGRATION false)
    find_package(Compiler REQUIRED)
  endif()

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationA request to change/fix/improve the documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions