Faster decoding, thanks to fewer bound checks. (#203)

Author: fabianfett

Package.swift

@@ -13,7 +13,7 @@ let package = Package(
         .library(name: "PostgresNIO", targets: ["PostgresNIO"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/apple/swift-nio.git", from: "2.33.0"),
+        .package(url: "https://github.com/apple/swift-nio.git", from: "2.35.0"),
         .package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.14.1"),
         .package(url: "https://github.com/apple/swift-crypto.git", "1.0.0" ..< "3.0.0"),
         .package(url: "https://github.com/apple/swift-metrics.git", from: "2.0.0"),

Sources/PostgresNIO/Message/PostgresMessage+Authentication.swift

@@ -23,7 +23,7 @@ extension PostgresMessage {
             case 10:
                 var mechanisms: [String] = []
                 while buffer.readableBytes > 0 {
-                    guard let nextString = buffer.psqlReadNullTerminatedString() else {
+                    guard let nextString = buffer.readNullTerminatedString() else {
                         throw PostgresError.protocol("Could not parse SASL mechanisms from authentication message")
                     }
                     if nextString.isEmpty {
@@ -68,7 +68,7 @@ extension PostgresMessage {
             case .saslMechanisms(let mechanisms):
                 buffer.writeInteger(10, as: Int32.self)
                 mechanisms.forEach {
-                    buffer.psqlWriteNullTerminatedString($0)
+                    buffer.writeNullTerminatedString($0)
                 }
             case .saslContinue(let challenge):
                 buffer.writeInteger(11, as: Int32.self)

Sources/PostgresNIO/Message/PostgresMessage+Bind.swift

@@ -39,8 +39,8 @@ extension PostgresMessage {
 
         /// Serializes this message into a byte buffer.
         public func serialize(into buffer: inout ByteBuffer) {
-            buffer.psqlWriteNullTerminatedString(self.portalName)
-            buffer.psqlWriteNullTerminatedString(self.statementName)
+            buffer.writeNullTerminatedString(self.portalName)
+            buffer.writeNullTerminatedString(self.statementName)
 
             buffer.write(array: self.parameterFormatCodes)
             buffer.write(array: self.parameters) {

Sources/PostgresNIO/Message/PostgresMessage+Close.swift

@@ -33,7 +33,7 @@ extension PostgresMessage {
         /// Serializes this message into a byte buffer.
         public func serialize(into buffer: inout ByteBuffer) throws {
             buffer.writeInteger(target.rawValue)
-            buffer.psqlWriteNullTerminatedString(name)
+            buffer.writeNullTerminatedString(name)
         }
     }
 }

Sources/PostgresNIO/Message/PostgresMessage+CommandComplete.swift

@@ -5,7 +5,7 @@ extension PostgresMessage {
     public struct CommandComplete: PostgresMessageType {
         /// Parses an instance of this message type from a byte buffer.
         public static func parse(from buffer: inout ByteBuffer) throws -> CommandComplete {
-            guard let string = buffer.psqlReadNullTerminatedString() else {
+            guard let string = buffer.readNullTerminatedString() else {
                 throw PostgresError.protocol("Could not parse close response message")
             }
             return .init(tag: string)

Sources/PostgresNIO/Message/PostgresMessage+Describe.swift

@@ -31,7 +31,7 @@ extension PostgresMessage {
         /// Serializes this message into a byte buffer.
         public func serialize(into buffer: inout ByteBuffer) {
             buffer.writeInteger(command.rawValue)
-            buffer.psqlWriteNullTerminatedString(name)
+            buffer.writeNullTerminatedString(name)
         }
     }
 }

Sources/PostgresNIO/Message/PostgresMessage+Error.swift

@@ -11,7 +11,7 @@ extension PostgresMessage {
         public static func parse(from buffer: inout ByteBuffer) throws -> Error {
             var fields: [Field: String] = [:]
             while let field = buffer.readInteger(as: Field.self) {
-                guard let string = buffer.psqlReadNullTerminatedString() else {
+                guard let string = buffer.readNullTerminatedString() else {
                     throw PostgresError.protocol("Could not read error response string.")
                 }
                 fields[field] = string

Sources/PostgresNIO/Message/PostgresMessage+Execute.swift

@@ -20,7 +20,7 @@ extension PostgresMessage {
 
         /// Serializes this message into a byte buffer.
         public func serialize(into buffer: inout ByteBuffer) {
-            buffer.psqlWriteNullTerminatedString(portalName)
+            buffer.writeNullTerminatedString(portalName)
             buffer.writeInteger(self.maxRows)
         }
     }

Sources/PostgresNIO/Message/PostgresMessage+NotificationResponse.swift

@@ -10,10 +10,10 @@ extension PostgresMessage {
             guard let backendPID: Int32 = buffer.readInteger() else {
                 throw PostgresError.protocol("Invalid NotificationResponse message: unable to read backend PID")
             }
-            guard let channel = buffer.psqlReadNullTerminatedString() else {
+            guard let channel = buffer.readNullTerminatedString() else {
                 throw PostgresError.protocol("Invalid NotificationResponse message: unable to read channel")
             }
-            guard let payload = buffer.psqlReadNullTerminatedString() else {
+            guard let payload = buffer.readNullTerminatedString() else {
                 throw PostgresError.protocol("Invalid NotificationResponse message: unable to read payload")
             }
             return .init(backendPID: backendPID, channel: channel, payload: payload)

Sources/PostgresNIO/Message/PostgresMessage+ParameterStatus.swift

@@ -4,10 +4,10 @@ extension PostgresMessage {
     public struct ParameterStatus: PostgresMessageType, CustomStringConvertible {
         /// Parses an instance of this message type from a byte buffer.
         public static func parse(from buffer: inout ByteBuffer) throws -> ParameterStatus {
-            guard let parameter = buffer.psqlReadNullTerminatedString() else {
+            guard let parameter = buffer.readNullTerminatedString() else {
                 throw PostgresError.protocol("Could not read parameter from parameter status message")
             }
-            guard let value = buffer.psqlReadNullTerminatedString() else {
+            guard let value = buffer.readNullTerminatedString() else {
                 throw PostgresError.protocol("Could not read value from parameter status message")
             }
             return .init(parameter: parameter, value: value)