Skip to content

Commit 206566f

Browse files
committed
source: make multiple derived classes final
Multiple derived classes were using virtual functions in their ctor/dtor. For this to work reliably we declare the classes final, to not produce complex construct/destruct scenarios if someone where to derive from these classes. Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
1 parent 6e0117a commit 206566f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

SilKit/source/core/participant/Participant.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ namespace SilKit {
8181
namespace Core {
8282

8383
template <class SilKitConnectionT>
84-
class Participant : public IParticipantInternal
84+
class Participant final : public IParticipantInternal
8585
{
8686
public:
8787
// ----------------------------------------

SilKit/source/tracing/PcapReader.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace SilKit {
1313
namespace Tracing {
1414

15-
class PcapReader : public SilKit::IReplayChannelReader
15+
class PcapReader final : public SilKit::IReplayChannelReader
1616
{
1717
public:
1818
// Constructors

SilKit/source/tracing/detail/NamedPipeLinux.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace SilKit {
1111
namespace Tracing {
1212
namespace Detail {
1313

14-
class NamedPipeLinux : public NamedPipe
14+
class NamedPipeLinux final : public NamedPipe
1515
{
1616
public:
1717
// ----------------------------------------

0 commit comments

Comments
 (0)