ci: add clang_tidy to the CI #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VJanKraemer
force-pushed
the
add_clang_tidy
branch
3 times, most recently
from
b7d0475 to
b6ed223
Compare
VJanKraemer
force-pushed
the
add_clang_tidy
branch
from
9d12d49 to
f5d1c31
Compare
Issues: SILKIT-1652 Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
Multiple derived classes were using virtual functions in their ctor/dtor. For this to work reliably we declare the classes final, to not produce complex construct/destruct scenarios if someone where to derive from these classes. Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
.gitignore do not adhere to regex, but their own glob based pattern matching. Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
VJanKraemer
force-pushed
the
add_clang_tidy
branch
from
f5d1c31 to
03557a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: SILKIT-1652
Subject
Add clang-tidy to CI builds
Description
Add clang-tidy to our CI builds. Generate warnings only at first.
Developer checklist (address before review)