add many type hints

Author: vincent-peugnet

app/class/Application.php

@@ -17,11 +17,11 @@ public function __construct()
         $this->usermanager = new Modeluser();
     }
 
-    public function wakeup()
+    public function wakeup(): void
     {
         if (isset($_POST['configinit'])) {
             if (Config::readconfig()) {
-                Config::createconfig($_POST['configinit']);
+                Config::hydrate($_POST['configinit']);
             } else {
                 Config::hydrate($_POST['configinit']);
             }
@@ -91,7 +91,7 @@ public function wakeup()
         }
     }
 
-    protected function configform()
+    protected function configform(): void
     {
         ?>
         <h1>Configuration</h1>
@@ -172,7 +172,7 @@ protected function configform()
         <?php
     }
 
-    protected function adminform()
+    protected function adminform(): void
     {
         ?>
 
@@ -207,7 +207,7 @@ protected function adminform()
     /**
      * Create default bookmarks set during install
      */
-    protected function defaultbookmarks()
+    protected function defaultbookmarks(): void
     {
         $bookmarkmanager = new Modelbookmark();
         if (empty($bookmarkmanager->list())) {

app/class/Bookmark.php

@@ -31,9 +31,11 @@ class Bookmark extends Item
     protected string $ref = "";
 
     /**
+     * @param object|array $datas
+     *
      * @throws RuntimeException
      */
-    public function __construct($datas = [])
+    public function __construct(mixed $datas = [])
     {
         $this->hydrateexception($datas);
     }
@@ -44,7 +46,7 @@ public function init(
         string $icon = '⭐',
         string $name = '',
         string $description = ''
-    ) {
+    ): void {
         $this->setid($id);
         $this->setquery($query);
         $this->seticon($icon);
@@ -66,7 +68,7 @@ public function ispublished(): bool
     // _____________________________ G E T __________________________________
 
 
-    public function id()
+    public function id(): string
     {
         return $this->id;
     }
@@ -81,12 +83,12 @@ public function description(): string
         return $this->description;
     }
 
-    public function query()
+    public function query(): string
     {
         return $this->query;
     }
 
-    public function icon()
+    public function icon(): string
     {
         return $this->icon;
     }
@@ -140,30 +142,24 @@ public function setdescription(string $description): bool
         }
     }
 
-    public function setquery($query)
+    public function setquery(string $query): void
     {
-        if (is_string($query)) {
-            $this->query = strip_tags(mb_substr($query, 0, Model::MAX_QUERY_LENGH));
-        }
+        $this->query = strip_tags(mb_substr($query, 0, Model::MAX_QUERY_LENGH));
     }
 
-    public function seticon($icon)
+    public function seticon(string $icon): void
     {
-        if (is_string($icon)) {
-            $this->icon = mb_substr(strip_tags($icon), 0, 16);
-        }
+        $this->icon = mb_substr(strip_tags($icon), 0, 16);
     }
 
-    public function setuser($user)
+    public function setuser(string $user): void
     {
-        if (is_string($user)) {
-            $this->user = Model::idclean($user);
-            return true;
+        if (Model::idcheck($user)) {
+            $this->user = $user;
         }
-        return false;
     }
 
-    public function setpublished(bool $published)
+    public function setpublished(bool $published): void
     {
         $this->published = $published;
     }

app/class/Clock.php

@@ -159,9 +159,9 @@ public function setformat(string $format): void
         }
     }
 
-    public function setlang($lang)
+    public function setlang(string $lang): void
     {
-        if (is_string($lang) && strlen($lang) < Config::LANG_MAX && strlen($lang) >= Config::LANG_MIN) {
+        if (strlen($lang) < Config::LANG_MAX && strlen($lang) >= Config::LANG_MIN) {
             $this->lang = $lang;
         }
     }

app/class/Config.php

@@ -81,8 +81,10 @@ abstract class Config
     // _______________________________________ F U N _______________________________________
 
 
-
-    public static function hydrate(array $datas): void
+    /**
+     * @param object|array $datas
+     */
+    public static function hydrate(mixed $datas): void
     {
         foreach ($datas as $key => $value) {
             $method = 'set' . $key;
@@ -108,11 +110,6 @@ public static function readconfig(): bool
         }
     }
 
-    public static function createconfig(array $datas): void
-    {
-        self::hydrate($datas);
-    }
-
     /**
      * @throws Filesystemexception          If file cant be saved
      */
@@ -124,7 +121,7 @@ public static function savejson(): bool
     }
 
 
-    public static function tojson(): string
+    protected static function tojson(): string
     {
         $arr = get_class_vars(get_class());
         // get_class_vars returns default values, we need to update each of them with the current one

app/class/Item.php

@@ -72,7 +72,7 @@ public function hydratejob($datas = []): array
      * Export Item Object as an array in order to store it in the database
      *
      * @param string $dateformat        Date formating for DateTime properties {@see Item::datetransform()}
-     * @return array                    Item as an associative array
+     * @return array<string, mixed>     Item as an associative array
      */
     public function dry(string $dateformat = "string"): array
     {
@@ -119,7 +119,7 @@ public function aa(array $arr, string $dateformat): array
      * @param string[]                  $vars list of vars
      * @param string $dateformat        Date formating for DateTime properties {@see Item::datetransform()}
      * @throws InvalidArgumentException if a listed property does not exist or is an object or array
-     * @return array                    Associative array `$var => $value`
+     * @return array<string, mixed>     Associative array `var => value`
      */
     public function drylist(array $vars, string $dateformat = "string"): array
     {

app/class/Logger.php

@@ -11,6 +11,7 @@
  */
 class Logger
 {
+    /** @var resource|false */
     private static $file = false;
     private static int $verbosity = 4;