Skip to content

Commit a44f0ba

Browse files
Merge branch 'biosimulations_fixes' of https://github.com/virtualcell/vcell into biosimulations_fixes
2 parents 781e91b + ab4e014 commit a44f0ba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

vcell-cli/src/test/java/org/vcell/cli/run/BSTSBasedOmexExecTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,10 @@ public static Collection<String> testCases() {
135135
Set<String> modelsToFilter = new HashSet<>();
136136
Predicate<String> filter;
137137

138-
modelsToFilter.addAll(needToCurateModels());
138+
modelsToFilter.addAll(needToCurateModels()); // Comment out if checking that current version will satisfy BSTS
139139
modelsToFilter.addAll(blacklistedModels());
140140
filter = (t) -> !modelsToFilter.contains(t);
141+
141142
return Arrays.stream(BSTSBasedTestSuiteFiles.getBSTSTestCases()).filter(filter).collect(Collectors.toList());
142143
}
143144

vcell-core/src/main/java/org/vcell/sedml/SEDMLImporter.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -826,11 +826,10 @@ private BioModel getModelReference(String referenceId, Model model, Map<String,
826826
throw new RuntimeException("The parent hasn't been processed yet!");
827827

828828
canTranslate = this.canTranslateToOverrides(parentBiomodel, model);
829-
return !model.getListOfChanges().isEmpty() && canTranslate ?
830-
parentBiomodel : this.importModel(model);
831-
} else {
832-
return this.importModel(model);
829+
if (canTranslate)
830+
return parentBiomodel;
833831
}
832+
return this.importModel(model);
834833
}
835834

836835
private boolean canTranslateToOverrides(BioModel refBM, Model mm) {

0 commit comments

Comments
 (0)