From cf895a0ac0a085d7d1030d5d46eaf480bf7811a1 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 8 Jul 2025 09:42:20 +0900 Subject: [PATCH 1/3] test: test no refresh transform for non-jsx files --- playground/react/App.jsx | 3 +++ playground/react/__tests__/react.spec.ts | 6 ++++++ playground/react/non-jsx/test.ts | 7 +++++++ 3 files changed, 16 insertions(+) create mode 100644 playground/react/non-jsx/test.ts diff --git a/playground/react/App.jsx b/playground/react/App.jsx index c7ffb805..cfa13d80 100644 --- a/playground/react/App.jsx +++ b/playground/react/App.jsx @@ -6,6 +6,7 @@ import { JsxImportRuntime } from './hmr/jsx-import-runtime' import { CountProvider } from './context/CountProvider' import { ContextButton } from './context/ContextButton' import { TestImportAttributes } from './import-attributes/test' +import { TEST_NON_JSX, TestNonJsx } from './non-jsx/test' function App() { const [count, setCount] = useState(0) @@ -42,6 +43,8 @@ function App() { + {TestNonJsx()} + {TEST_NON_JSX()} ) } diff --git a/playground/react/__tests__/react.spec.ts b/playground/react/__tests__/react.spec.ts index f9d4275a..89d70a8b 100644 --- a/playground/react/__tests__/react.spec.ts +++ b/playground/react/__tests__/react.spec.ts @@ -148,4 +148,10 @@ if (!isBuild) { expect(await page.textContent('#state-button')).toMatch('count is: 1') }) + + test('no refresh transform for non-jsx files', async () => { + const res = await page.request.get(viteTestUrl + '/non-jsx/test.ts') + const code = await res.text() + expect(code).not.toContain('$RefreshReg$') + }) } diff --git a/playground/react/non-jsx/test.ts b/playground/react/non-jsx/test.ts new file mode 100644 index 00000000..ec12ec12 --- /dev/null +++ b/playground/react/non-jsx/test.ts @@ -0,0 +1,7 @@ +export const TestNonJsx = () => { + return 'TestNonJsx' +} + +export const TEST_NON_JSX = () => { + return 'TEST_NON_JSX' +} From 718c5ea2fe3f9e241a5310eda148a639ab620c7f Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 8 Jul 2025 09:45:36 +0900 Subject: [PATCH 2/3] chore: test https://github.com/vitejs/rolldown-vite/pull/318 --- pnpm-lock.yaml | 11 ++++++----- pnpm-workspace.yaml | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index cda6eb11..762d7e79 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -7,7 +7,7 @@ settings: catalogs: rolldown-vite: vite: - specifier: npm:rolldown-vite@^7.0.5 + specifier: https://pkg.pr.new/vitejs/rolldown-vite@318 version: 7.0.5 packageExtensionsChecksum: sha256-S82yCctxnlOTNFuHWCyTFRo/B6Y3jque/4DnsDO4WZA= @@ -136,7 +136,7 @@ importers: version: 3.5.0(typescript@5.8.3) vite: specifier: catalog:rolldown-vite - version: rolldown-vite@7.0.5(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1) + version: rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1) packages/plugin-react-swc: dependencies: @@ -5039,8 +5039,9 @@ packages: vue-tsc: optional: true - rolldown-vite@7.0.5: - resolution: {integrity: sha512-z239GrVtwr+DVgFw6s64Wa+OLjE4aG1Ux+MeVdQKXes0XaIDja5ouacPDLExgpSlplbe0zxSb1JbYtFvOr+pIw==} + rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318: + resolution: {tarball: https://pkg.pr.new/vitejs/rolldown-vite@318} + version: 7.0.5 engines: {node: ^20.19.0 || >=22.12.0} hasBin: true peerDependencies: @@ -9829,7 +9830,7 @@ snapshots: - oxc-resolver - supports-color - rolldown-vite@7.0.5(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1): + rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1): dependencies: '@oxc-project/runtime': 0.75.0 fdir: 6.4.6(picomatch@4.0.2) diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 7471e6f9..fef6e080 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -6,4 +6,4 @@ packages: catalogs: rolldown-vite: - vite: npm:rolldown-vite@^7.0.5 + vite: https://pkg.pr.new/vitejs/rolldown-vite@318 From 18a57dfba45949e1dd3dd628272ae6ac34eca2e5 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 8 Jul 2025 09:53:56 +0900 Subject: [PATCH 3/3] Revert "chore: test https://github.com/vitejs/rolldown-vite/pull/318" This reverts commit 718c5ea2fe3f9e241a5310eda148a639ab620c7f. --- pnpm-lock.yaml | 11 +++++------ pnpm-workspace.yaml | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 762d7e79..cda6eb11 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -7,7 +7,7 @@ settings: catalogs: rolldown-vite: vite: - specifier: https://pkg.pr.new/vitejs/rolldown-vite@318 + specifier: npm:rolldown-vite@^7.0.5 version: 7.0.5 packageExtensionsChecksum: sha256-S82yCctxnlOTNFuHWCyTFRo/B6Y3jque/4DnsDO4WZA= @@ -136,7 +136,7 @@ importers: version: 3.5.0(typescript@5.8.3) vite: specifier: catalog:rolldown-vite - version: rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1) + version: rolldown-vite@7.0.5(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1) packages/plugin-react-swc: dependencies: @@ -5039,9 +5039,8 @@ packages: vue-tsc: optional: true - rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318: - resolution: {tarball: https://pkg.pr.new/vitejs/rolldown-vite@318} - version: 7.0.5 + rolldown-vite@7.0.5: + resolution: {integrity: sha512-z239GrVtwr+DVgFw6s64Wa+OLjE4aG1Ux+MeVdQKXes0XaIDja5ouacPDLExgpSlplbe0zxSb1JbYtFvOr+pIw==} engines: {node: ^20.19.0 || >=22.12.0} hasBin: true peerDependencies: @@ -9830,7 +9829,7 @@ snapshots: - oxc-resolver - supports-color - rolldown-vite@https://pkg.pr.new/vitejs/rolldown-vite@318(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1): + rolldown-vite@7.0.5(@types/node@22.16.0)(esbuild@0.25.5)(jiti@2.4.2)(tsx@4.20.3)(yaml@2.7.1): dependencies: '@oxc-project/runtime': 0.75.0 fdir: 6.4.6(picomatch@4.0.2) diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index fef6e080..7471e6f9 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -6,4 +6,4 @@ packages: catalogs: rolldown-vite: - vite: https://pkg.pr.new/vitejs/rolldown-vite@318 + vite: npm:rolldown-vite@^7.0.5