From dce5ac410c1953aeec6eb2b614216e91e0e9d99e Mon Sep 17 00:00:00 2001
From: Oscar Dijkhoff <oscar.dijkhoff@enova.nl>
Date: Mon, 24 Nov 2025 14:50:58 +0100
Subject: [PATCH] fix(install script)!: exit with non-zero exit code on error

---
 dev/unix/volta-install.sh | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/dev/unix/volta-install.sh b/dev/unix/volta-install.sh
index fddaaa616..327a00883 100755
--- a/dev/unix/volta-install.sh
+++ b/dev/unix/volta-install.sh
@@ -221,15 +221,17 @@ install_version() {
       ;;
   esac
 
-  if [ "$?" == 0 ]
-  then
-      if [ "$should_run_setup" == "true" ]; then
-        info 'Finished' "installation. Updating user profile settings."
-        "$install_dir"/bin/volta setup
-      else
-        "$install_dir"/bin/volta --version &>/dev/null # creates the default shims
-        info 'Finished' "installation. No changes were made to user profile settings."
-      fi
+  local install_status="$?"
+  if [ "$install_status" -ne 0 ]; then
+    return "$install_status"
+  fi
+
+  if [ "$should_run_setup" == "true" ]; then
+    info 'Finished' "installation. Updating user profile settings."
+    "$install_dir"/bin/volta setup
+  else
+    "$install_dir"/bin/volta --version &>/dev/null # creates the default shims
+    info 'Finished' "installation. No changes were made to user profile settings."
   fi
 }