Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Commit 92be692

Browse files
authored
Small fix on signing procedure (#153)
1 parent f7646a7 commit 92be692

File tree

1 file changed

+6
-29
lines changed

1 file changed

+6
-29
lines changed

.github/workflows/package.yml

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
- name: Build
2929
working-directory: ${{github.workspace}}/build
3030
run: cmake --build . -t DolbyIO.Comms.Native
31+
3132
- if: ${{matrix.os == 'macos-latest'}}
3233
env:
3334
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
@@ -52,11 +53,6 @@ jobs:
5253
xcrun notarytool store-credentials "dotnet-sdk-notarization-profile" --apple-id "iapi@dolby.com" --team-id B55NRA8BRW --password "${IAPI_DOTNET_APP_SPECYFIC_PASSWORD}"
5354
codesign --force --strict --timestamp --sign 'Developer ID Application: VOXEET INC. (B55NRA8BRW)' *.dylib
5455
55-
56-
- name: Pack
57-
working-directory: ${{github.workspace}}/build
58-
run: dotnet pack dotnet/${{ matrix.runtime }}/${{ matrix.runtime }}.csproj
59-
6056
- if: ${{matrix.os == 'windows-latest'}}
6157
working-directory: ${{github.workspace}}/build/bin
6258
run: |
@@ -67,6 +63,11 @@ jobs:
6763
& 'C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe' sign /f ./certificate.pfx /p ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD}} /t http://timestamp.digicert.com/ dolbyio_comms_sdk.dll
6864
& 'C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe' sign /f ./certificate.pfx /p ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD}} /t http://timestamp.digicert.com/ dolbyio_comms_media.dll
6965
Remove-Item -Recurse -Force certificate.pfx
66+
67+
- name: Pack
68+
working-directory: ${{github.workspace}}/build
69+
run: dotnet pack dotnet/${{ matrix.runtime }}/${{ matrix.runtime }}.csproj
70+
7071
- uses: actions/upload-artifact@v3
7172
with:
7273
name: nugets
@@ -80,27 +81,6 @@ jobs:
8081
with:
8182
submodules: true
8283
lfs: true
83-
- name: Install the Apple certificate and notarization profile
84-
env:
85-
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
86-
P12_PASSWORD: ${{ secrets.P12_PASSWORD }}
87-
BUILD_PROVISION_PROFILE_BASE64: ${{ secrets.BUILD_PROVISION_PROFILE_BASE64 }}
88-
KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }}
89-
IAPI_DOTNET_APP_SPECYFIC_PASSWORD: ${{ secrets.IAPI_DOTNET_APP_SPECYFIC_PASSWORD }}
90-
run: |
91-
# create variables
92-
CERTIFICATE_PATH=$RUNNER_TEMP/build_certificate.p12
93-
KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db
94-
# import certificate and provisioning profile from secrets
95-
echo -n "$BUILD_CERTIFICATE_BASE64" | base64 --decode -o $CERTIFICATE_PATH
96-
# create temporary keychain
97-
security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
98-
security set-keychain-settings -lut 21600 $KEYCHAIN_PATH
99-
security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
100-
# import certificate to keychain
101-
security import $CERTIFICATE_PATH -P "$P12_PASSWORD" -A -t cert -f pkcs12 -k $KEYCHAIN_PATH
102-
security list-keychain -d user -s $KEYCHAIN_PATH
103-
xcrun notarytool store-credentials "dotnet-sdk-notarization-profile" --apple-id "iapi@dolby.com" --team-id B55NRA8BRW --password "${IAPI_DOTNET_APP_SPECYFIC_PASSWORD}"
10484
- uses: ./.github/actions/configure
10585
- uses: actions/download-artifact@v3
10686
with:
@@ -135,9 +115,6 @@ jobs:
135115
- run: 7z x "${{github.workspace}}/build/bin/DolbyIO.Comms.Sdk.Runtime.*.nupkg" -o${{github.workspace}}/build "runtimes/*"
136116
working-directory: ${{github.workspace}}/build
137117

138-
- name: Sign osx libs
139-
run: |
140-
codesign --force --strict --timestamp --sign 'Developer ID Application: VOXEET INC. (B55NRA8BRW)' ${{github.workspace}}/build/runtimes/osx-universal/native/*.dylib
141118
- uses: actions/upload-artifact@v3
142119
with:
143120
name: dolbyio-dotnet-binaries

0 commit comments

Comments
 (0)