Users should be created before the database

Databases in MongoDB are created lazy, meaning there is no `create`
command. Thus if a record is inserted the DB is created.  When auth is
enabled, any attempt to insert data is denied because of missing auth.
However the `db.createUser()` function works because of the config
option `enableBypassLocalAuth`. For an overview see
https://www.mongodb.com/docs/manual/tutorial/deploy-replica-set-with-keyfile-access-control/

Author: stevenpost

lib/puppet/type/mongodb_user.rb

@@ -117,7 +117,7 @@ def insync?(_is)
     %w[mongodb mongod]
   end
 
-  autorequire(:mongodb_database) do
+  autobefore(:mongodb_database) do
     self[:database]
   end
 

spec/acceptance/user_spec.rb

@@ -14,8 +14,9 @@ class { 'mongodb::globals':
         }
         -> class { 'mongodb::server': }
         -> class { 'mongodb::client': }
-        -> mongodb_database { 'testdb': ensure => present }
-        ->
+
+        mongodb_database { 'testdb': ensure => present }
+
         mongodb_user {'testuser':
           ensure        => present,
           password_hash => mongodb_password('testuser', 'passw0rd'),
@@ -40,8 +41,9 @@ class { 'mongodb::globals':
         }
         -> class { 'mongodb::server': }
         -> class { 'mongodb::client': }
-        -> mongodb_database { 'testdb': ensure => present }
-        ->
+
+        mongodb_database { 'testdb': ensure => present }
+
         mongodb_user {'testuser':
           ensure        => absent,
           password_hash => mongodb_password('testuser', 'passw0rd'),
@@ -68,8 +70,9 @@ class { 'mongodb::globals':
         }
         -> class { 'mongodb::server': port => 27018 }
         -> class { 'mongodb::client': }
-        -> mongodb_database { 'testdb': ensure => present }
-        ->
+
+        mongodb_database { 'testdb': ensure => present }
+
         mongodb_user {'testuser':
           ensure        => present,
           password_hash => mongodb_password('testuser', 'passw0rd'),
@@ -96,8 +99,9 @@ class { 'mongodb::globals':
         }
         -> class { 'mongodb::server': }
         -> class { 'mongodb::client': }
-        -> mongodb_database { 'testdb': ensure => present }
-        ->
+
+        mongodb_database { 'testdb': ensure => present }
+
         mongodb_user {'testuser':
           ensure        => present,
           password_hash => mongodb_password('testuser', 'passw0rd'),
@@ -125,16 +129,18 @@ class { 'mongodb::globals':
         }
         -> class { 'mongodb::server': }
         -> class { 'mongodb::client': }
-        -> mongodb_database { 'testdb': ensure => present }
-        -> mongodb_database { 'testdb2': ensure => present }
-        ->
+
+        mongodb_database { 'testdb': ensure => present }
+
+        mongodb_database { 'testdb2': ensure => present }
+
         mongodb_user {'testuser':
           ensure        => present,
           password_hash => mongodb_password('testuser', 'passw0rd'),
           database      => 'testdb',
           roles         => ['readWrite', 'dbAdmin'],
         }
-        ->
+
         mongodb_user {'testuser2':
           ensure        => present,
           password_hash => mongodb_password('testuser2', 'passw0rd'),

spec/defines/db_spec.rb

@@ -25,7 +25,7 @@
           is_expected.to contain_mongodb_user('User testuser on db testdb'). \
             with_username('testuser'). \
             with_database('testdb'). \
-            that_requires('Mongodb_database[testdb]')
+            that_comes_before('Mongodb_database[testdb]')
         end
 
         it 'contains mongodb_user with proper roles' do
@@ -65,7 +65,7 @@
           is_expected.to contain_mongodb_user('User testuser on db testdb'). \
             with_username('testuser'). \
             with_database('testdb'). \
-            that_requires('Mongodb_database[testdb]')
+            that_comes_before('Mongodb_database[testdb]')
         end
 
         it 'contains mongodb_user with proper roles' do