Skip to content

Conversation

@Frityet
Copy link

@Frityet Frityet commented Oct 30, 2025

No description provided.

@Frityet
Copy link
Author

Frityet commented Oct 30, 2025

Next would be teal type definition, but thats for a diff pr

@Frityet
Copy link
Author

Frityet commented Oct 31, 2025

Next would be teal type definition, but thats for a diff pr

actually @vtrlx should I just put that in this PR too?

@vtrlx
Copy link
Owner

vtrlx commented Oct 31, 2025

I'll start with the prerequisite question: Did you vibe code this?

I'm hesitant to accept this pull due to my unfamiliarity with LSP—not to mention that I simply have a distaste for this sort of thing. That said, I'm not going to reject this PR out of hand. I'm just totally unfamiliar with this particular problem space.

Second question is, what does this script give you as an LSP user? Have you used this script to get full code suggestions for GObject libraries on your system?

Lastly, has any thought been given to making this work in a Flatpak? Users are likely to use LuaGObject within Flatpak to ensure their projects use the latest versions of GObject libraries like GTK and Adwaita. It'd be a bit jarring if their LSP's suggestions weren't accurate to the library versions that a project is actually using, but I wouldn't be surprised if it's difficult or awkward to pull it off. Just a nice-to-have.

@Frityet
Copy link
Author

Frityet commented Nov 2, 2025

I'll start with the prerequisite question: Did you vibe code this?

I didn't, should I have?

I'm hesitant to accept this pull due to my unfamiliarity with LSP—not to mention that I simply have a distaste for this sort of thing. That said, I'm not going to reject this PR out of hand. I'm just totally unfamiliar with this particular problem space.

Second question is, what does this script give you as an LSP user? Have you used this script to get full code suggestions for GObject libraries on your system?

I have and currently use it for projects, this way your LSP tells you what methods you can use, catches type mismatches, and does completions

Lastly, has any thought been given to making this work in a Flatpak? Users are likely to use LuaGObject within Flatpak to ensure their projects use the latest versions of GObject libraries like GTK and Adwaita. It'd be a bit jarring if their LSP's suggestions weren't accurate to the library versions that a project is actually using, but I wouldn't be surprised if it's difficult or awkward to pull it off. Just a nice-to-have.

I wasn't really thinking it'd be used user-side at all, it would be whoever is developing the application just downloading and running this script when they need

@vtrlx
Copy link
Owner

vtrlx commented Nov 6, 2025

I'll start with the prerequisite question: Did you vibe code this?

I didn't, should I have?

I'm going to doubt that assertion, given this:

Screenshot From 2025-11-06 07-53-22

If you wrote a comment soliciting a "review" from an LLM-backed bot, it puts your submission in doubt. Subsequently deleting the comment makes it look like you're actively hiding AI use.

Closing.

@vtrlx vtrlx closed this Nov 6, 2025
@Frityet
Copy link
Author

Frityet commented Nov 6, 2025

I'm going to doubt that assertion, given this:

Nah, that was to try it out cause I haven't really used these tools before. Nothing happened when I pinged it so I deleted it cause it didn't do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants