Rename to shouldDismissOnReturn

Author: adborbas

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormTableViewDataSource.swift

@@ -208,7 +208,7 @@ private extension ProductFormTableViewDataSource {
                                                                    productStatus: productStatus,
                                                                    placeholder: placeholder,
                                                                    textViewMinimumHeight: 10.0,
-                                                                   dismissOnReturn: true,
+                                                                   shouldDismissOnReturn: true,
                                                                    isScrollEnabled: false,
                                                                    onNameChange: { [weak self] (newName) in self?.onNameChange?(newName) },
                                                                    style: .headline)

WooCommerce/Classes/ViewRelated/ReusableViews/EnhancedTextView.swift

@@ -6,7 +6,7 @@ final class EnhancedTextView: UITextView {
 
     var onTextChange: ((String) -> Void)?
     var onTextDidBeginEditing: (() -> Void)?
-    var dismissOnReturn: Bool = false
+    var shouldDismissOnReturn: Bool = false
 
     var placeholder: String? {
         didSet {
@@ -89,7 +89,7 @@ extension EnhancedTextView: UITextViewDelegate {
                   shouldChangeTextIn range: NSRange,
                   replacementText text: String) -> Bool {
 
-        if dismissOnReturn && text == "\n" {
+        if shouldDismissOnReturn && text == "\n" {
             textView.resignFirstResponder()
             return false
         }

WooCommerce/Classes/ViewRelated/ReusableViews/LabeledTextViewTableViewCell.swift

@@ -8,7 +8,7 @@ final class LabeledTextViewTableViewCell: UITableViewCell {
         var productStatus: ProductStatus
         var placeholder: String? = nil
         var textViewMinimumHeight: CGFloat? = nil
-        var dismissOnReturn: Bool = false
+        var shouldDismissOnReturn: Bool = false
         var isScrollEnabled: Bool = true
         var onNameChange: ((_ text: String) -> Void)? = nil
         var onTextDidBeginEditing: (() -> Void)? = nil
@@ -33,7 +33,7 @@ final class LabeledTextViewTableViewCell: UITableViewCell {
         productTextField.isScrollEnabled = viewModel.isScrollEnabled
         productTextField.onTextChange = viewModel.onNameChange
         productTextField.onTextDidBeginEditing = viewModel.onTextDidBeginEditing
-        productTextField.dismissOnReturn = viewModel.dismissOnReturn
+        productTextField.shouldDismissOnReturn = viewModel.shouldDismissOnReturn
         configureProductStatusLabel(productStatus: viewModel.productStatus)
         applyStyle(style: viewModel.style)
     }