Filter variations without a parent product in the catalog, as the API currently returns all products and variations with public status.

Author: jaclync

Modules/Sources/Yosemite/Tools/POS/POSCatalogPersistenceService.swift

@@ -27,6 +27,8 @@ final class POSCatalogPersistenceService: POSCatalogPersistenceServiceProtocol {
     func replaceAllCatalogData(_ catalog: POSCatalog, siteID: Int64) async throws {
         DDLogInfo("💾 Persisting catalog with \(catalog.products.count) products and \(catalog.variations.count) variations")
 
+        let catalog = filterOrphanedVariations(from: catalog)
+
         try await grdbManager.databaseConnection.write { db in
             DDLogInfo("🗑️ Clearing catalog data for site \(siteID)")
             try PersistedSite.deleteOne(db, key: siteID)
@@ -154,6 +156,22 @@ final class POSCatalogPersistenceService: POSCatalogPersistenceServiceProtocol {
     }
 }
 
+private extension POSCatalogPersistenceService {
+    /// Filters out variations whose parent products are not in the catalog.
+    /// This can happen when the API returns public variations but their parent products are not public.
+    func filterOrphanedVariations(from catalog: POSCatalog) -> POSCatalog {
+        let productIDs = catalog.products.map { $0.productID }
+        let variations = catalog.variations.filter { variation in
+            let parentExists = productIDs.contains { $0 == variation.productID }
+            if !parentExists {
+                DDLogWarn("Variation \(variation.productVariationID) references missing product \(variation.productID)")
+            }
+            return parentExists
+        }
+        return POSCatalog(products: catalog.products, variations: variations, syncDate: catalog.syncDate)
+    }
+}
+
 private extension POSCatalog {
     var productsToPersist: [PersistedProduct] {
         products.map { PersistedProduct(from: $0) }

Modules/Tests/YosemiteTests/Tools/POS/POSCatalogPersistenceServiceTests.swift

@@ -564,6 +564,42 @@ struct POSCatalogPersistenceServiceTests {
             #expect(site?.id == sampleSiteID)
         }
     }
+
+    // MARK: - Orphaned Variation Filtering Tests
+
+    @Test func replaceAllCatalogData_filters_out_variations_without_parent_products() async throws {
+        // Given
+        let product = POSProduct.fake().copy(siteID: sampleSiteID, productID: 10)
+        let validVariation = POSProductVariation.fake()
+            .copy(siteID: sampleSiteID, productID: 10, productVariationID: 1, image: ProductImage.fake().copy(imageID: 100))
+        let orphanedVariation1 = POSProductVariation.fake()
+            .copy(siteID: sampleSiteID, productID: 20, productVariationID: 2, image: ProductImage.fake().copy(imageID: 200))
+        let orphanedVariation2 = POSProductVariation.fake()
+            .copy(siteID: sampleSiteID, productID: 30, productVariationID: 3, image: ProductImage.fake().copy(imageID: 300))
+
+        let catalog = POSCatalog(
+            products: [product],
+            variations: [validVariation, orphanedVariation1, orphanedVariation2],
+            syncDate: .now
+        )
+
+        // When
+        try await sut.replaceAllCatalogData(catalog, siteID: sampleSiteID)
+
+        // Then
+        try await db.read { db in
+            let variationCount = try PersistedProductVariation.fetchCount(db)
+            #expect(variationCount == 1)
+            let variationImageCount = try PersistedProductVariationImage.fetchCount(db)
+            #expect(variationImageCount == 1)
+
+            let variation = try PersistedProductVariation.fetchOne(db)
+            #expect(variation?.id == 1)
+            #expect(variation?.productID == 10)
+            let variationImage = try PersistedProductVariationImage.fetchOne(db)
+            #expect(variationImage?.imageID == 100)
+        }
+    }
 }
 
 private extension POSCatalogPersistenceServiceTests {