Start syncs after updating catalog eligibility

Author: joshheald

WooCommerce/Classes/POS/TabBar/POSTabCoordinator.swift

@@ -42,6 +42,8 @@ final class POSTabCoordinator {
     private let pushNotesManager: PushNotesManager
     private let eligibilityChecker: POSEntryPointEligibilityCheckerProtocol
 
+    private lazy var posSyncDispatcher = ForegroundPOSCatalogSyncDispatcher()
+
     /// Local catalog eligibility service - created asynchronously during init
     private(set) var localCatalogEligibilityService: POSLocalCatalogEligibilityServiceProtocol?
 
@@ -134,18 +136,27 @@ final class POSTabCoordinator {
     /// Only checks eligibility if the POS tab is visible
     func updatePOSEligibility(isPOSTabVisible: Bool) {
         Task { @MainActor [weak self] in
-            guard let self, let service = self.localCatalogEligibilityService else { return }
+            guard let self, let catalogEligibilityService = self.localCatalogEligibilityService else { return }
 
             // If POS tab is not visible, mark as ineligible
             guard isPOSTabVisible else {
-                try await service.updatePOSEligibility(isEligible: false, for: siteID)
+                try await catalogEligibilityService.updatePOSEligibility(isEligible: false,
+                                                                         for: siteID)
+                await posSyncDispatcher.stop()
                 return
             }
 
             // Check actual POS eligibility using the eligibility checker
             let eligibilityState = await eligibilityChecker.checkEligibility()
             let isPOSEligible = eligibilityState == .eligible
-            try await service.updatePOSEligibility(isEligible: isPOSEligible, for: siteID)
+            do {
+                try await catalogEligibilityService.updatePOSEligibility(isEligible: isPOSEligible,
+                                                                         for: siteID)
+                // Only start syncs after we've updated the catalog eligibility.
+                await isPOSEligible ? posSyncDispatcher.start() : posSyncDispatcher.stop()
+            } catch {
+                await posSyncDispatcher.stop()
+            }
         }
     }
 

WooCommerce/Classes/ViewRelated/MainTabBarController.swift

@@ -152,7 +152,6 @@ final class MainTabBarController: UITabBarController {
 
     private var posTabVisibilityChecker: POSTabVisibilityCheckerProtocol?
     private var posEligibilityCheckTask: Task<Void, Never>?
-    private lazy var posSyncDispatcher = ForegroundPOSCatalogSyncDispatcher()
 
     /// periphery: ignore - keeping strong ref of the checker to keep its async task alive
     private var bookingsEligibilityChecker: BookingsTabEligibilityCheckerProtocol?
@@ -752,9 +751,6 @@ private extension MainTabBarController {
 
             // Update POS eligibility - coordinator will check actual eligibility if tab is visible
             posTabCoordinator?.updatePOSEligibility(isPOSTabVisible: isPOSTabVisible)
-
-            // Begin foreground synchronization if POS tab becomes visible
-            await isPOSTabVisible ? posSyncDispatcher.start() : posSyncDispatcher.stop()
         }
     }