Update booking order validation

RafaelKayumov · RafaelKayumov · commit d059642b5a8b · 2025-11-11T14:37:37.000+03:00
diff --git a/WooCommerce/Classes/Extensions/Booking+Helpers.swift b/WooCommerce/Classes/Extensions/Booking+Helpers.swift
@@ -19,8 +19,8 @@ extension Booking {
             .joined(separator: "  •  ")
     }
 
-    var isOrderValid: Bool {
-        return orderID != 0
+    var hasAssociatedOrder: Bool {
+        return orderID > 0
     }
 
     private enum Localization {
diff --git a/WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift b/WooCommerce/Classes/ViewModels/Booking Details/BookingDetailsViewModel.swift
@@ -84,7 +84,7 @@ private extension BookingDetailsViewModel {
 
     func updateDisplayProperties(from booking: Booking) {
         navigationTitle = Self.navigationTitle(for: booking)
-        isViewOrderAvailable = booking.isOrderValid
+        isViewOrderAvailable = booking.hasAssociatedOrder
 
         headerContent.update(with: booking)
 
diff --git a/WooCommerce/Classes/ViewModels/Booking Details/PaymentContent.swift b/WooCommerce/Classes/ViewModels/Booking Details/PaymentContent.swift
@@ -29,7 +29,7 @@ extension BookingDetailsViewModel {
             actions = [
                 .markAsPaid,
                 .issueRefund
-            ] + (booking.isOrderValid ? [.viewOrder] : [])
+            ] + (booking.hasAssociatedOrder ? [.viewOrder] : [])
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ extension Booking {`
`19`	`19`	`.joined(separator: " • ")`
`20`	`20`	`}`
`21`	`21`
`22`		`- var isOrderValid: Bool {`
`23`		`- return orderID != 0`
	`22`	`+ var hasAssociatedOrder: Bool {`
	`23`	`+ return orderID > 0`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`private enum Localization {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ extension BookingDetailsViewModel {`
`29`	`29`	`actions = [`
`30`	`30`	`.markAsPaid,`
`31`	`31`	`.issueRefund`
`32`		`- ] + (booking.isOrderValid ? [.viewOrder] : [])`
	`32`	`+ ] + (booking.hasAssociatedOrder ? [.viewOrder] : [])`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`}`