Merge pull request #1060 from wordpress-mobile/fix/crash-when-removing-media

Fix issue when removing media in the middle of a paragraph

Author: danilo04

aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

@@ -2254,7 +2254,7 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
                                     text.getSpanEnd(blockSpan),
                                     text.getSpanFlags(blockSpan)
                             )
-                        }
+                        }.filter { it.start >= start }
                         spans.forEach { temporarySpan ->
                             text.removeSpan(temporarySpan)
                         }

aztec/src/test/kotlin/org/wordpress/aztec/ImageBlockTest.kt

@@ -278,4 +278,38 @@ class ImageBlockTest {
 
         Assert.assertEquals(initialHtml, editText.toHtml())
     }
+
+    @Test
+    @Throws(Exception::class)
+    fun removeImageInSpanBeforeBlankLine() {
+        val initialHtml = "<p>Line 1</p><p>Line 2<img id=\"1234\" /><br>Line 3</p><p>Line 4</p>"
+        editText.fromHtml(initialHtml)
+
+        editText.setSelection(1)
+
+        editText.removeMedia(object : AztecText.AttributePredicate {
+            override fun matches(attrs: Attributes): Boolean {
+                return attrs.getValue("id") == "1234"
+            }
+        })
+
+        Assert.assertEquals("<p>Line 1</p><p>Line 2<br><br>Line 3</p><p>Line 4</p>", editText.toHtml())
+    }
+
+    @Test
+    @Throws(Exception::class)
+    fun removeImageInSpanAfterBlankLine() {
+        val initialHtml = "<p>Line 1</p><p>Line 2<br><img id=\"1234\" />Line 3</p><p>Line 4</p>"
+        editText.fromHtml(initialHtml)
+
+        editText.setSelection(1)
+
+        editText.removeMedia(object : AztecText.AttributePredicate {
+            override fun matches(attrs: Attributes): Boolean {
+                return attrs.getValue("id") == "1234"
+            }
+        })
+
+        Assert.assertEquals("<p>Line 1</p><p>Line 2<br>Line 3</p><p>Line 4</p>", editText.toHtml())
+    }
 }