Merge pull request #1065 from wordpress-mobile/fix/only-remove-actual-history-items

khaykov · web-flow · commit c36ac5f0cf0c · 2023-11-06T16:50:54.000-06:00
Do not iterate in while when history cursor is outside of list range
diff --git a/aztec/src/main/kotlin/org/wordpress/aztec/History.kt b/aztec/src/main/kotlin/org/wordpress/aztec/History.kt
@@ -61,7 +61,7 @@ class History(val historyEnabled: Boolean, val historySize: Int) {
             return
         }
 
-        while (historyCursor != historyList.size && historyCursor >= 0) {
+        while (historyCursor in 0 until historyList.size) {
             historyList.removeAt(historyCursor)
         }
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class History(val historyEnabled: Boolean, val historySize: Int) {`
`61`	`61`	`return`
`62`	`62`	`}`
`63`	`63`
`64`		`- while (historyCursor != historyList.size && historyCursor >= 0) {`
	`64`	`+ while (historyCursor in 0 until historyList.size) {`
`65`	`65`	`historyList.removeAt(historyCursor)`
`66`	`66`	`}`
`67`	`67`