Skip to content

Commit eadc097

Browse files
committed
Remove unnecessary params from upload_gutenberg_sourcemaps
1 parent 17ba9b9 commit eadc097

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

fastlane/lanes/build.rb

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,10 @@
3434
# Create the file names
3535
app = get_app_name_option!(options)
3636
version_name = current_version_name
37-
flavor = 'Vanilla'
38-
build_type = 'Release'
39-
build_bundle(app: app, version_name: version_name, build_code: current_build_code, flavor: flavor, buildType: build_type)
37+
build_bundle(app: app, version_name: version_name, build_code: current_build_code, flavor: 'Vanilla', buildType: 'Release')
4038

4139
upload_build_to_play_store(app: app, version_name: version_name, track: 'production')
42-
upload_gutenberg_sourcemaps(app: app, flavor: flavor, build_type: build_type, release_version: version_name)
40+
upload_gutenberg_sourcemaps(app: app, release_version: version_name)
4341

4442
create_gh_release(app: app, version_name: version_name) if options[:create_release]
4543
end
@@ -105,12 +103,10 @@
105103
# Create the file names
106104
app = get_app_name_option!(options)
107105
version_name = current_version_name
108-
flavor = 'Vanilla'
109-
build_type = 'Release'
110-
build_bundle(app: app, version_name: version_name, build_code: current_build_code, flavor: flavor, buildType: build_type)
106+
build_bundle(app: app, version_name: version_name, build_code: current_build_code, flavor: 'Vanilla', buildType: 'Release')
111107

112108
upload_build_to_play_store(app: app, version_name: version_name, track: 'beta') if options[:upload_to_play_store]
113-
upload_gutenberg_sourcemaps(app: app, flavor: flavor, build_type: build_type, release_version: version_name)
109+
upload_gutenberg_sourcemaps(app: app, release_version: version_name)
114110

115111
create_gh_release(app: app, version_name: version_name, prerelease: true) if options[:create_release]
116112
end
@@ -223,7 +219,7 @@
223219
)
224220

225221
upload_prototype_build(product: 'WordPress', version_name: version_name)
226-
upload_gutenberg_sourcemaps(app: 'Wordpress', flavor: PROTOTYPE_BUILD_FLAVOR, build_type: PROTOTYPE_BUILD_TYPE, release_version: version_name)
222+
upload_gutenberg_sourcemaps(app: 'Wordpress', release_version: version_name)
227223
end
228224

229225
#####################################################################################
@@ -247,7 +243,7 @@
247243
)
248244

249245
upload_prototype_build(product: 'Jetpack', version_name: version_name)
250-
upload_gutenberg_sourcemaps(app: 'Jetpack', flavor: PROTOTYPE_BUILD_FLAVOR, build_type: PROTOTYPE_BUILD_TYPE, release_version: version_name)
246+
upload_gutenberg_sourcemaps(app: 'Jetpack', release_version: version_name)
251247
end
252248

253249
#####################################################################################
@@ -372,11 +368,9 @@ def generate_prototype_build_number
372368
# These files are provided by the Gutenberg Mobile library.
373369
#
374370
# @param [String] app App name, e.g. 'WordPress' or 'Jetpack'.
375-
# @param [String] flavor Build flavor, e.g. 'Jalapeno' or 'Vanilla'.
376-
# @param [String] build_type Build type, e.g. 'Debug' or 'Release'.
377371
# @param [String] release_version Release version name to attach the files to in Sentry.
378372
#
379-
def upload_gutenberg_sourcemaps(app:, flavor:, build_type:, release_version:)
373+
def upload_gutenberg_sourcemaps(app:, release_version:)
380374
# Load Sentry properties
381375
sentry_path = File.join(PROJECT_ROOT_FOLDER, 'WordPress', 'src', app.downcase, 'sentry.properties')
382376
sentry_properties = JavaProperties.load(sentry_path)

0 commit comments

Comments
 (0)